On 11 Dec 2022 20:44, Fangrui Song wrote:
> On Sat, Dec 10, 2022 at 9:33 PM Mike Frysinger wrote:
> > On 10 Dec 2022 16:26, Indu Bhagat wrote:
> > > This patch is essentially a revert of
> > > commit-id: 8818c80cbd4116ef5af171ec47c61167179e225c
> > > (libctf: Add ZSTD_LIBS to LIBS so that ac_cv_libctf_bfd_elf can be true)
> > >
> > > As the specific configure check now uses libtool, this explicit mention of the
> > > dependency $ZSTD_LIBS is not needed anymore.
> > >
> > > As for AC_ZSTD, it was suggested to clean it up (https://sourceware.org/pipermail/binutils/2022-December/125026.html)
> > > as it is unused. Althought this patch does remove AC_ZSTD from
> > > libctf/configure.ac, I am not completely sure anymore: libctf may have
> > > plans to support zstd compressed CTF sections soon/later ?
> >
> > if libctf ever gains such support, it's easy enough to add back in.
> >
> > lgtm
> 
> The revert will likely be problematic. Some members of libbfd.a
> reference ZSTD_* symbols. Without -lzstd, these references will be
> dangling unless -Wl,--gc-sections is specifies and essentially
> discards input sections which reference ZSTD_*.

we don't link -lbfd, we link libbfd.la via libtool, and it takes care of
specifying any dependent libraries that libbfd uses.
-mike