From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 39FDF3887F75 for ; Mon, 12 Dec 2022 09:48:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 39FDF3887F75 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 91B893410F8; Mon, 12 Dec 2022 09:48:00 +0000 (UTC) Date: Mon, 12 Dec 2022 18:47:59 +0900 From: Mike Frysinger To: Fangrui Song Cc: Indu Bhagat , binutils@sourceware.org, nick.alcock@oracle.com Subject: Re: [PATCH] libctf: remove unnecessary zstd constructs Message-ID: References: <20221211002622.564875-1-indu.bhagat@oracle.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4/Jlwoma6TQMVOBT" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --4/Jlwoma6TQMVOBT Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 11 Dec 2022 20:44, Fangrui Song wrote: > On Sat, Dec 10, 2022 at 9:33 PM Mike Frysinger wrote: > > On 10 Dec 2022 16:26, Indu Bhagat wrote: > > > This patch is essentially a revert of > > > commit-id: 8818c80cbd4116ef5af171ec47c61167179e225c > > > (libctf: Add ZSTD_LIBS to LIBS so that ac_cv_libctf_bfd_elf can be tr= ue) > > > > > > As the specific configure check now uses libtool, this explicit menti= on of the > > > dependency $ZSTD_LIBS is not needed anymore. > > > > > > As for AC_ZSTD, it was suggested to clean it up (https://sourceware.o= rg/pipermail/binutils/2022-December/125026.html) > > > as it is unused. Althought this patch does remove AC_ZSTD from > > > libctf/configure.ac, I am not completely sure anymore: libctf may have > > > plans to support zstd compressed CTF sections soon/later ? > > > > if libctf ever gains such support, it's easy enough to add back in. > > > > lgtm >=20 > The revert will likely be problematic. Some members of libbfd.a > reference ZSTD_* symbols. Without -lzstd, these references will be > dangling unless -Wl,--gc-sections is specifies and essentially > discards input sections which reference ZSTD_*. we don't link -lbfd, we link libbfd.la via libtool, and it takes care of specifying any dependent libraries that libbfd uses. -mike --4/Jlwoma6TQMVOBT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmOW+M4ACgkQQWM7n+g3 9YFZ5xAAhwV3RTwqJA/4kUYyj8y3sJGfXykcQ9+qEex0Yv6848TbQJq0fB/eFL94 U85uJOxXcejk8hT173oWqv5Mw0TyjRw5fBWf0dTAdP3ISETHLBpL+raIr0iETpY1 lsipCvoojBsP7tq3zpYfUeJNIbrYlpFEox2yHB7anZiTfj2fp6Ep30XbdlTcKTko ZTSR8fvUyTPMMw+DLtEn0QpdUbaWsVN9EUKkESMDMNuqFdyON6uj2bEso681lHRp LHjHLzGTW+dKbqdu5PkqcTA6VEeJ1vIvpcyp7l1093K+l6owBV+k/juYggIIMp+L 6arsz7qPfh/YVsoVyCIJbnyZE0U3IFoCZlwUUPqryz2Uhq8NilH0iO5MWx4WjwY1 PvFLwmlblqXubtGdnWjWc9+YG6oFqBvUPiEus28RH1NtSZ/fE+BUi/YlRV25fSyO 9dOKdo3zdZfSV8zIDtDTopf38DMDWRAP2QNgoaeEm+p6E5VHkUfP2abhM648XJPY pct/FAAx+HOZdYdt0v4JdLGKfOtOP0jPsK3IP/tchO7gQeYuR+Ye0wJkc6OWw2ao bC8JgVIiKwFX+58ZKSChGK1T7xen7UWBRmfyXzelcL14FWburONfMvKKw8omNpul Br+MmV1HgQJf1X8j6WiaI+2t1cJvHFa3ga6ybsJjMO7nSnKTL4I= =wwk1 -----END PGP SIGNATURE----- --4/Jlwoma6TQMVOBT--