From: Alan Modra <amodra@gmail.com>
To: Mark Harmstone <mark@harmstone.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH 1/3] ld: Handle extended-length data structures in PDB types
Date: Sat, 31 Dec 2022 19:28:09 +1030 [thread overview]
Message-ID: <Y6/5ofjfA4J+46i9@squeak.grove.modra.org> (raw)
In-Reply-To: <20221226204751.23761-1-mark@harmstone.com>
On Mon, Dec 26, 2022 at 08:47:49PM +0000, Mark Harmstone wrote:
> A few fixes to minor issues I've discovered in my PDB patches.
>
> * If sizes or offsets are greater than 0x8000, they get encoded as
> extended values in the same way as for enum values - e.g. a LF_ULONG
> .short followed by a .long.
>
> * I've managed to coax MSVC to produce another type, LF_VFTABLE, which
> is seen when dealing with COM. I don't think LLVM emits this. Note that
> we can't just implement everything in Microsoft's header files, as most
> of it is obsolete.
>
> * Fixes a stupid bug in the test program, where I was adding an index to
> a size. The index was hard-coded to 0, so this didn't cause any actual
> issues.
I pushed these three patches for you.
--
Alan Modra
Australia Development Lab, IBM
prev parent reply other threads:[~2022-12-31 8:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-26 20:47 Mark Harmstone
2022-12-26 20:47 ` [PATCH 2/3] ld: Handle LF_VFTABLE types in PDBs Mark Harmstone
2022-12-26 20:47 ` [PATCH 3/3] ld/testsuite: Don't add index to sizes in pdb.exp Mark Harmstone
2022-12-31 8:58 ` Alan Modra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6/5ofjfA4J+46i9@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=mark@harmstone.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).