From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id A9BC03858D28 for ; Mon, 19 Dec 2022 22:59:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A9BC03858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x62c.google.com with SMTP id u7so2308756plq.11 for ; Mon, 19 Dec 2022 14:59:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=xIhqCsqaIdO+mvPa85iMeORjcKsH4CTa/W19RDD1w4I=; b=jWtYHjM9xB15yjFDTLRgwvkx6Hmv/LcZ2/AVIN3jNMZ1YavWlqEEO5Dm8ByrVVieJs rYp7MSEDOW07uoyvw7K+Axoj4yYFQkDhN5ty2qMKqWE5INewBccejrIDdICq4j9++ip4 yahwf96k1KMRDlaoe6JPtzmTF9oGFtryo70eJCmu2Ui9vJ4Ljk3RG+wahVSI/FXO38cr M5MVScRtT3L8Q8rjvoA19y3RY+tfAkrP98c4z3vU/AhIidhACpW/RruwBrwBgr9BCSut 29xs4myATU6ocCKEWa0qMJmiaXiKBd2nf7mlmM5KWUtxRS8U4yHoP6wpMCJVWdhjLlXe s43g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xIhqCsqaIdO+mvPa85iMeORjcKsH4CTa/W19RDD1w4I=; b=ddVxeWnERTl5gc09AdiLcp35icLJIHf4tqtBldy9rY3e5mnaHlrFmkV5su3I3Ap9g/ MbxfSTe0LmBLWEvWJFCaj8AdhvZuLnwg158/1csaqr7ZMoTh4axPPeo+yL2H0QFXnj7I nEgR06OXPX5OSMiQ6KYp86nzA0K+Ewd2DoKRoywPyM5+W5SwucBRAEbX+qkPSO/saCnb 0SWcspfDo3rnLYuBJO4ITd/7Zx0iw3BQfK1809S4uxZiLW3WWfF3OdUAoRRuM4evRMNd K+84x1SL/75Sq54ZHvpeGEwadZjOp/i8m6Rn4b4wMqeofLNPYNKl8zVJd90LhWx1mbga qTzw== X-Gm-Message-State: AFqh2kpGigjAzEatodhg2aRN5yRIVxNWU89aSj+2sgo8C7wET9eG4p+e T4FTAh80y+qs9cDFJQ+HHQxn3Rtssp0= X-Google-Smtp-Source: AMrXdXvSj//ZikA1FczA/elct6LNl9VeysOJPCI7XcPWj3cOO4KHRn4EZnk2PxPgIDMzB+9y+uyx0g== X-Received: by 2002:a17:902:704a:b0:191:7d3:7fdd with SMTP id h10-20020a170902704a00b0019107d37fddmr10459347plt.60.1671490790643; Mon, 19 Dec 2022 14:59:50 -0800 (PST) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:a57b:7d53:5916:3824]) by smtp.gmail.com with ESMTPSA id j5-20020a170902da8500b00189a7fbff33sm7713275plx.170.2022.12.19.14.59.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Dec 2022 14:59:50 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id B426211400D5; Tue, 20 Dec 2022 09:29:47 +1030 (ACDT) Date: Tue, 20 Dec 2022 09:29:47 +1030 From: Alan Modra To: =?iso-8859-1?Q?Torbj=F6rn?= SVENSSON Cc: binutils@sourceware.org, christophe.lyon@arm.com, Yvan ROUX Subject: Re: [PATCH v2] bfd: Discard region regardless of warning flag Message-ID: References: <20221219183450.3754890-1-torbjorn.svensson@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221219183450.3754890-1-torbjorn.svensson@foss.st.com> X-Spam-Status: No, score=-3028.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Dec 19, 2022 at 07:34:51PM +0100, Torbjörn SVENSSON via Binutils wrote: > v1 -> v2: > Added testcase > > Ok for trunk? This is OK except for a few minor things. > I have commit access for GDB. Do I still need someone to push this for > me or do I automatically have write access to the complete binutils > repository and just need the approval to push it myself? You should be able to push it. > The discard of the region should be performed regardless if the warning This should say "The discard of symbols in..." not "The discard of...". The code here is handling symbols. > for the discard is enabled or not. > +++ b/ld/testsuite/ld-arm/non-contiguous-arm7.d > @@ -0,0 +1,4 @@ > +#name: non-contiguous-arm7 > +#source: non-contiguous-arm7.s > +#ld: --enable-non-contiguous-regions -T non-contiguous-arm7.ld --gc-sections Please remove --gc-sections. The testcase doesn't need it. -- Alan Modra Australia Development Lab, IBM