From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by sourceware.org (Postfix) with ESMTPS id D2BE53858281 for ; Thu, 22 Dec 2022 09:43:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D2BE53858281 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x42f.google.com with SMTP id 124so870634pfy.0 for ; Thu, 22 Dec 2022 01:43:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zs1064exhUyNQFu8EHxaWdQ019QzSZCTsco5mMADcN8=; b=J+h7d8PpTN7RoMV7KfjHcJRBQsFyHljzosq+KBINHbaN1PfCqKUz7KfgaLjACMRFfQ mkSxbcQXWImTxZIx7Iu5C8tx5lI4+oOoxmVr9OV1X8UUDDLi+hoPj4SPDsmb0Z0UjiZ7 chLRtKpOzWvlSVyKYoA+8r6scWLaMtUPXtuD9zUSv+NN17Nf4J2SF4qeMRsRPEWQDZa+ N2Qt5oRw0pdAMHKT1+QP3IEqfXwpga+q5tO0i1b8iRFu+wym5usOBbs8//j5EeYQO+JD oz1pGv1UqFl3QSBR2lUaI+2yN9uE4TjL4Q3wB1pb3wNe3Qdu6ha5dQGJPQUWbAbqVQuq 4CqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zs1064exhUyNQFu8EHxaWdQ019QzSZCTsco5mMADcN8=; b=NqekHnxrWa4Xg848g8uSz2nW+k5H8RcrQvi3zgcvQ849GLiJPfIfVlfkk+4gEgkk+Z n10KvYgzu1MMJbLeVXc5/88rg3ahowNkoxPxewFzC+m/fRBXM/1LNaxVCeelw/YJPNrx 7UHSmCZGZcZtx7mKT7aI8g5qLtKqgRmWVTR1dSSDF6QPwfnuZfpszow0dPrUaiEmCXRC FMMXSyOVpfg4RzbVUS7N5aFU+dSvA48hIUxt0fFND+Ls+cF+FHIYIBxZDs0Jq7+rTDGw fujWu4fgvu6lfodZ9u/ObCPyWp7IFZRPpAM9LN5xh49bJSFHs1C90KxFjEejdwatDvih v1cQ== X-Gm-Message-State: AFqh2kriCr2iWhbcpOmmnG1MpSflKOqWgeExBEwTBWyafIW1YTfjKgn5 pOTqLArJ3BL4JfnYRSJEi8ZHAguJ5wY= X-Google-Smtp-Source: AMrXdXsyxGxR6FGKygAJEeaE6Yp0JYIfe+ALueud1/lpx172F2wYRcHnZUT5N3SoQjwW3VL06SOmaQ== X-Received: by 2002:aa7:843c:0:b0:578:128b:3a3f with SMTP id q28-20020aa7843c000000b00578128b3a3fmr5671224pfn.15.1671702185718; Thu, 22 Dec 2022 01:43:05 -0800 (PST) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:ff9a:bf9c:868:302c]) by smtp.gmail.com with ESMTPSA id f186-20020a6251c3000000b0056c3a0dc65fsm276347pfb.71.2022.12.22.01.43.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Dec 2022 01:43:05 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 0A25911400D5; Thu, 22 Dec 2022 20:13:03 +1030 (ACDT) Date: Thu, 22 Dec 2022 20:13:03 +1030 From: Alan Modra To: Jan Beulich Cc: binutils@sourceware.org Subject: Re: x86: remove i386-opc.c Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-3035.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Dec 22, 2022 at 09:49:41AM +0100, Jan Beulich wrote: > On 20.12.2022 12:39, Alan Modra wrote: > > On Tue, Dec 20, 2022 at 09:40:14AM +0100, Jan Beulich wrote: > >> On 20.12.2022 09:33, Alan Modra via Binutils wrote: > >>> Regen opcodes/po/POTFILES.in > >>> > >>> diff --git a/opcodes/po/POTFILES.in b/opcodes/po/POTFILES.in > >>> index 9906bf14848..effd73f8f78 100644 > >>> --- a/opcodes/po/POTFILES.in > >>> +++ b/opcodes/po/POTFILES.in > >>> @@ -73,7 +73,6 @@ h8300-dis.c > >>> hppa-dis.c > >>> i386-dis.c > >>> i386-gen.c > >>> -i386-opc.c > >>> i386-opc.h > >>> ia64-asmtab.c > >>> ia64-asmtab.h > >> > >> Which makes me wonder: If this is the list of files where string literals > >> may/will need translation, are files like i386-gen.c (i.e. build time > >> helper tool sources) really supposed to be enumerated here? > > > > Probably not, but the build time tools don't tend to use gettext and > > thus all it does is slow down generation of .pot files a little. > > Irrespective of them using gettext (I've now queued a patch to remove > that from i386-gen.c), wouldn't it make sense to convert > > POTFILES = $(HFILES) $(CFILES) > > to > > POTFILES = $(HFILES) $(LIBOPCODES_CFILES) > > thus eliminating translation for build time tools regardless? At which > point the question would be whether CFILES as a variable needs retaining. > Afaics the definition of POTFILES is the only user. Sounds reasonable to me. -- Alan Modra Australia Development Lab, IBM