From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id C02983858425 for ; Thu, 22 Dec 2022 10:22:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C02983858425 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x636.google.com with SMTP id w20so1573414ply.12 for ; Thu, 22 Dec 2022 02:22:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3SEA9GJz+LaQjRuSZyGp9HJjMno2LtS8mb/7PNVI1W0=; b=StDX2a1xUYoz8PLMaioMOQNdaqJa0L4wDaND1GU5gMH/jNjtglbcoWkHS8TU/YbpYu CD6iKUSoO0Q63ABnO6Q6a2h0S1vM5YOtIpD2FxMaJUWkgesmTY+0iKGQHcTM9vHIQ+v7 qnUn8gknOSnwgVrVRnSGYuSEAyFZHmPQZUh4oSD8aC5JrWtbkiQ1utFvqgPUHz+L7Xvp Klw2z+1QOTRDXS87cnuw48PbEZp5r/CO4FjGc+aTj6cQHPYL6U8qU/7ouNLEY0eT0iDL iIfHCvz8RKna4rvISpGXXev9VvLdFibjSE0Phqyol7G7Zp3vn+evgScKQw+YOLFiIatq k8gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3SEA9GJz+LaQjRuSZyGp9HJjMno2LtS8mb/7PNVI1W0=; b=WYnnQYkDYFDn0kTT6h7vRGtxvNjUdfu1yu3/1s6VYChZlRb0iKS5E+ewbyGIxoJ+pe agFpUqlNxd2zffHRJrlC1dPnyhgCZrdidmMbS9v/O5wlReUk+gLoeyxJ7O7x7Mpm4K3a 1zi+VYVUREpwDv45cKlEaWUY6S1xJilDglBjFb7rNEFjEdhXpARxj4k5RagmSWlwnGTn qE+GNlcAikNt5VfLWBAasBemsLy8l5Cz/T8y9nJFQU38zyeqeYJT/krajBZcqGyoMbSz Tb2vFqmbU7qLWBu5sTE/yMmlh6uptIBrhI/zjQPtmLsFro4fExozi4Bh/SmPU+8Cipgr iRvw== X-Gm-Message-State: AFqh2kqu46P7PKerhfJ7l9PCHhCgg1wSDesIc66RYIdVj1s6xksw10/4 Q2N7V5aBQhXgJqT7WMpz2ts= X-Google-Smtp-Source: AMrXdXsr9XGZuzM8tvpIcC2CeYgeS4uIB6tV7ZXBvQLgmtBvvhvbDBE8nThFGHWHpjZ1N3CKN46Kxg== X-Received: by 2002:a17:902:ab8b:b0:189:77c1:b5ad with SMTP id f11-20020a170902ab8b00b0018977c1b5admr19133661plr.20.1671704568791; Thu, 22 Dec 2022 02:22:48 -0800 (PST) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:ff9a:bf9c:868:302c]) by smtp.gmail.com with ESMTPSA id d15-20020a170902cecf00b0019248880f75sm195743plg.77.2022.12.22.02.22.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Dec 2022 02:22:48 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id DC15B11400D5; Thu, 22 Dec 2022 20:52:45 +1030 (ACDT) Date: Thu, 22 Dec 2022 20:52:45 +1030 From: Alan Modra To: Mark Harmstone Cc: binutils@sourceware.org, nickc@redhat.com Subject: Re: [PATCH 01/10] ld: Generate PDB string table Message-ID: References: <20221209015240.6348-1-mark@harmstone.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-3028.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: There is also this: ld/pdb.h:571 /* lfUdtModSrcLine in cvinfo.h */ struct lf_udt_mod_src_line { uint16_t size; uint16_t kind; uint32_t type; uint32_t source_file_string; uint32_t line_no; uint16_t module_no; } ATTRIBUTE_PACKED; ld/pdb.c:2286 memcpy (&umsl->line_no, &usl->line_no, sizeof (uint16_t)); which results in uninitialised data. -- Alan Modra Australia Development Lab, IBM