From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Subject: now_seg after closing output file
Date: Wed, 11 Jan 2023 16:36:26 +1030 [thread overview]
Message-ID: <Y75R4sYOPg/8UuHm@squeak.grove.modra.org> (raw)
now_seg, a pointer into the output file sections, isn't valid after
the output file is closed. gas doesn't and shouldn't use now_seg
after this point of course, but let's be safe.
* output-file.c (output_file_close): Clear now_seg and now_subseg.
diff --git a/gas/output-file.c b/gas/output-file.c
index 127dc735703..0c3a8115bb1 100644
--- a/gas/output-file.c
+++ b/gas/output-file.c
@@ -99,6 +99,8 @@ output_file_close (void)
res = bfd_cache_close_all ();
else
res = bfd_close (obfd);
+ now_seg = NULL;
+ now_subseg = 0;
filename = out_file_name;
out_file_name = NULL;
--
Alan Modra
Australia Development Lab, IBM
reply other threads:[~2023-01-11 6:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y75R4sYOPg/8UuHm@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).