From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by sourceware.org (Postfix) with ESMTPS id C41123857B93 for ; Wed, 11 Jan 2023 13:14:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C41123857B93 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x102f.google.com with SMTP id z1-20020a17090a66c100b00226f05b9595so2004432pjl.0 for ; Wed, 11 Jan 2023 05:14:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=DLKjgckHwpn8nMJaea/zExBeHp07ccRg4foNi8AwkPA=; b=VHGOvh0Y7KzX0CGNyBzYxqDlNesaAMzJRLhlKOPpJq1H5WVGee9wZPcXbI9N/naa40 WQMO8K8ZKG2ccilWa7tFyn1qyUN1c8SoL9qjLaRjiOA8HjrOieX5S4e0KyCDHhCJKoEY u1qm6Ak39vimFIsuyHN4svA+BDInk/pYomHcRVJdjpjFOQcUrPU1JM2m0C0M5Bk6tVod 7ImQ+M5ZWuw3mrc0g7RYUzE7NiQK/L2UO7RvRRy19ZvdrEG8kovT5lA/+A0xbsic7++5 UnXjE4ExMTwfixVz6u7An5oSqAV26UQSfhJC6mVY13qPlzeXpVGbyPVGJjtcVCdV3MEL LFyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DLKjgckHwpn8nMJaea/zExBeHp07ccRg4foNi8AwkPA=; b=xqCAzU8341/2vHmVxvCZRGu5v9bg3Kaw38ThMOOMgCGcGrsw8GrJw2XHJtvlsTEU/1 MfYCAMZb6F66t5nXyEEPOteErYTZyDwQ1PxriBrbejpNkQdCAFihY180C0/WyVKksMe8 gzikNvAGH9XYu0KTMKZ4/2iz/P20td3BU+qwWTr0ykFqsat7s3dzHeS3qusEKWPP3AwP 21/ah+cMK0hdHWU33OU7jybu37IJEQxYxPX7j+H3CAL1dYIIkrgtDDoPlLewVyUrsrXG 6YmoEQ1GYDvmdLBgnonA0jnaCvR5tprUY0HFXd2VG5ZBgGCCJ0zyIKT8tGD78GP2e/d1 D4IQ== X-Gm-Message-State: AFqh2krKTs4RFohAn696rurd6imQsvMkzBO9jHBwFSmA7Ju19irEcPj3 mrmUQpcjAWsN55oflIgW4LxSslKsK10= X-Google-Smtp-Source: AMrXdXuhsXMJ/vnVa6967raaqYRi09jn1JApOYwQINmphgsefmgVarTHTOrAhRQlchIgmEVn7+H+Kg== X-Received: by 2002:a05:6a20:8409:b0:a7:16c4:d2c4 with SMTP id c9-20020a056a20840900b000a716c4d2c4mr3496788pzd.47.1673442894632; Wed, 11 Jan 2023 05:14:54 -0800 (PST) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:32e3:1a56:4865:4775]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c10400b00194529543bdsm647006pli.25.2023.01.11.05.14.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jan 2023 05:14:54 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id C11B41142CD2; Wed, 11 Jan 2023 23:44:51 +1030 (ACDT) Date: Wed, 11 Jan 2023 23:44:51 +1030 From: Alan Modra To: binutils@sourceware.org Subject: Fix XPASS weak symbols on x86_64-mingw32 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3034.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Fixes commit 16fea92ccd99. * testsuite/ld-scripts/weak.exp: Don't xfail x86_64 PE targets. Do xfail other PE OS triplets by moving code setting xfails. diff --git a/ld/testsuite/ld-scripts/weak.exp b/ld/testsuite/ld-scripts/weak.exp index bf6f8862571..9df57c7d97f 100644 --- a/ld/testsuite/ld-scripts/weak.exp +++ b/ld/testsuite/ld-scripts/weak.exp @@ -23,20 +23,21 @@ set testname "weak symbols" # This test only works for ELF targets and some PE targets. # It ought to work for some a.out targets, but it doesn't. -if {! [is_elf_format] && ! [is_pecoff_format]} { +if { [is_elf_format] } { + # hppa64 is incredibly broken + setup_xfail hppa64-*-* +} elseif { [is_pecoff_format] } { + # Weak symbols are broken for most PE targets. + if { ![istarget i?86-*-*] + && ![istarget sh-*-*] + && ![istarget x86_64-*-*] } { + setup_xfail *-*-* + } +} else { unsupported $testname return } -# Weak symbols are broken for most PE targets. -if {! [istarget i?86-*-*] && ! [istarget sh-*-*]} { - setup_xfail *-*-pe* - setup_xfail *-*-mingw* -} - -# hppa64 is incredibly broken -setup_xfail hppa64-*-* - if {! [ld_assemble $as $srcdir/$subdir/weak1.s tmpdir/weak1.o] || ! [ld_assemble $as $srcdir/$subdir/weak2.s tmpdir/weak2.o]} then { # It's OK if .weak doesn't work on this target. -- Alan Modra Australia Development Lab, IBM