From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by sourceware.org (Postfix) with ESMTPS id E59A83858D35 for ; Wed, 4 Jan 2023 13:28:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E59A83858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x1036.google.com with SMTP id v23so36090453pju.3 for ; Wed, 04 Jan 2023 05:28:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=uxlhjeqRpEWSZEeMXAAn/OWPUiKF8xYxJFgZX+PpeF0=; b=NZOvnvG94KzC/ZNK9WO9PmqsXAbxy/Jcq3WaAURyFi6VAbAz9bXO0CTIRy4YzIuhaf tJzLjThuPpUgKylEioYVhviPs6QW6RMaXygFkX7LpBTy4oqYb0xqd4wRj2Ymt/Orq6TT Sbhrc4PemyS3R3QmXOLFrqjS3D2VilDP6oEC3YSl/AQmpukwWC/AjrTIKh+LVzMeKDMX VXgmmRH+wm2WDrzcNdqXDQfKPppUq5awq5Ezl4lsKwO4TtGbfVNPqtjiFiBd9p4AmFFA vRhxn2etJMQ+XfdN1RSdI+/kkEk8V7yzgQFSi5eT+X6aE/KYxxa3Bi5i2JrF1WSv3sdz Yn3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uxlhjeqRpEWSZEeMXAAn/OWPUiKF8xYxJFgZX+PpeF0=; b=0GBXAyjoeH3LFbpssXDa7+LGtzll+LdZIT1VNKxQY1Sy2QfUiFhHB8TkgPPcoB5T5r JgRMjdmmHXsyC3oNXAwpIuJyMCEr0Vr1+LlGWBgAkue+JXIrA3FIghspUcA+3cQ7HshT v6zxO+KsMyZ2m8uJ5Hsx12CIi4D8qiGJyArkAV9E66QrXkEa083JDFKwCG1O9IfzCdj3 RN4DxrKV1IkDQa6rtE9gz9xrfGmwK8ug16x679gDK9zAmueapA98U7vjjSaAJ/y8m4y9 3XQifAjEzIrOCFbHA2eNB9yfL0zSVP/thj1Tu8ndLkFJJssww3cQK2gek76MehAHv3Qa Di8Q== X-Gm-Message-State: AFqh2kqlnB3Y+62ci64RJb0SHCFhGqjpwjZ8FSBBd9Vye/dWa3RIcvmx nxlT8cxnjoPCmgXx6szRioDwTxYFuxo= X-Google-Smtp-Source: AMrXdXuFwjmH9G2e5MBpKgl6//1WVPo6ZMUJ6g9a4FYc0QNGHOvbu50MP3Yk1kWnkvW32w0Nx3pxwg== X-Received: by 2002:a17:90b:110a:b0:223:2001:4ee8 with SMTP id gi10-20020a17090b110a00b0022320014ee8mr50713335pjb.27.1672838928736; Wed, 04 Jan 2023 05:28:48 -0800 (PST) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:934:e2e8:56f6:280a]) by smtp.gmail.com with ESMTPSA id i10-20020a17090a65ca00b00218cd71781csm20231572pjs.51.2023.01.04.05.28.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 05:28:48 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 27FC91142CDF; Wed, 4 Jan 2023 23:58:46 +1030 (ACDT) Date: Wed, 4 Jan 2023 23:58:46 +1030 From: Alan Modra To: binutils@sourceware.org Subject: Re: Avoid unaligned pointer reads in PEP .idata section Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3035.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Fix testsuite fallout. * testsuite/ld-pe/cfi.d: Adjust for changed .idata padding. * testsuite/ld-pe/secidx_64.d: Likewise. * testsuite/ld-pe/secrel_64.d: Likewise. diff --git a/ld/testsuite/ld-pe/cfi.d b/ld/testsuite/ld-pe/cfi.d index 55ebaca1aef..9ae0ec77881 100644 --- a/ld/testsuite/ld-pe/cfi.d +++ b/ld/testsuite/ld-pe/cfi.d @@ -4,7 +4,7 @@ #objdump: -Wf #... -0+4 0+14 0*ffffffff CIE +0+ 0+14 0*ffffffff CIE Version: 1 Augmentation: "" Code alignment factor: 1 @@ -20,7 +20,7 @@ DW_CFA_nop DW_CFA_nop -0+1c 0+24 0+4 FDE cie=0+4 pc=.* +0+18 0+24 0+ FDE cie=0+ pc=.* DW_CFA_advance_loc: 4 to .* DW_CFA_def_cfa_offset: 16 DW_CFA_offset: r6 \(rbp\) at cfa\-16 diff --git a/ld/testsuite/ld-pe/secidx_64.d b/ld/testsuite/ld-pe/secidx_64.d index ddf4aec74f9..63b4a589c70 100644 --- a/ld/testsuite/ld-pe/secidx_64.d +++ b/ld/testsuite/ld-pe/secidx_64.d @@ -2,26 +2,26 @@ tmpdir/secidx\.x: +file format pei-.* Contents of section \.text: - .*1000 3e3e3e3e 3c3c3c3c 3e3e3e3e 3e3c3c3c >>>><<<<>>>>><<< - .*1010 3e3e3e3e 3e3e3c3c 3e3e3e3e 3e3e3e3c >>>>>><<>>>>>>>< - .*1020 3c3c3c3c 3e3e3e3e 3e909090 90909090 <<<<>>>>>....... - .*1030 ffffffff ffffffff 00000000 00000000 ................ - .*1040 ffffffff ffffffff 00000000 00000000 ................ + .*1000 3e3e3e3e 3c3c3c3c 3e3e3e3e 3e3c3c3c .* + .*1010 3e3e3e3e 3e3e3c3c 3e3e3e3e 3e3e3e3c .* + .*1020 3c3c3c3c 3e3e3e3e 3e909090 90909090 .* + .*1030 ffffffff ffffffff 00000000 00000000 .* + .*1040 ffffffff ffffffff 00000000 00000000 .* Contents of section \.data: - .*2000 3e3e3e3e 3c3c3c3c 3e3e3e3e 3e3c3c3c >>>><<<<>>>>><<< - .*2010 3e3e3e3e 3e3e3c3c 3e3e3e3e 3e3e3e3c >>>>>><<>>>>>>>< - .*2020 3e3e3e3e 01001101 00110100 11010011 >>>>............ - .*2030 3c3c3c3c 3c3c3c3c 3e3e3e3e 02001102 <<<<<<<<>>>>.... - .*2040 00110200 11020011 3c3c3c3c 3c3c3c3c ........<<<<<<<< - .*2050 3e3e3e3e 03001103 00110300 11030011 >>>>............ - .*2060 3c3c3c3c 3c3c3c3c 3e3e3e3e 01001102 <<<<<<<<>>>>.... - .*2070 00110300 113c3c3c 3c3c3c3c 3c000000 .....<<<<<<<<... - .*2080 3c3c3c3e 3e3e3e3e 3e000000 00000000 <<<>>>>>>....... + .*2000 3e3e3e3e 3c3c3c3c 3e3e3e3e 3e3c3c3c .* + .*2010 3e3e3e3e 3e3e3c3c 3e3e3e3e 3e3e3e3c .* + .*2020 3e3e3e3e 01001101 00110100 11010011 .* + .*2030 3c3c3c3c 3c3c3c3c 3e3e3e3e 02001102 .* + .*2040 00110200 11020011 3c3c3c3c 3c3c3c3c .* + .*2050 3e3e3e3e 03001103 00110300 11030011 .* + .*2060 3c3c3c3c 3c3c3c3c 3e3e3e3e 01001102 .* + .*2070 00110300 113c3c3c 3c3c3c3c 3c000000 .* + .*2080 3c3c3c3e 3e3e3e3e 3e000000 00000000 .* Contents of section \.rdata: - .*3000 3e3e3e3e 3c3c3c3c 3e3e3e3e 3e3c3c3c >>>><<<<>>>>><<< - .*3010 3e3e3e3e 3e3e3c3c 3e3e3e3e 3e3e3e3c >>>>>><<>>>>>>>< - .*3020 3e3e3e3e 00000000 00000000 00000000 >>>>............ - .*3030 3c3c3c3e 3e3e3e3e 3e000000 00000000 <<<>>>>>>....... + .*3000 3e3e3e3e 3c3c3c3c 3e3e3e3e 3e3c3c3c .* + .*3010 3e3e3e3e 3e3e3c3c 3e3e3e3e 3e3e3e3c .* + .*3020 3e3e3e3e 00000000 00000000 00000000 .* + .*3030 3c3c3c3e 3e3e3e3e 3e000000 00000000 .* Contents of section \.idata: - .*4000 00000000 00000000 00000000 00000000 ................ - .*4010 00000000 .... + .*4000 00000000 00000000 00000000 00000000 .* + .*4010 00000000 00000000 .* diff --git a/ld/testsuite/ld-pe/secrel_64.d b/ld/testsuite/ld-pe/secrel_64.d index aba1bf11c69..82284f9cf62 100644 --- a/ld/testsuite/ld-pe/secrel_64.d +++ b/ld/testsuite/ld-pe/secrel_64.d @@ -1,28 +1,28 @@ - -tmpdir/secrel\.x: +file format pei-.* - -Contents of section \.text: - .*1000 3e3e3e3e 3c3c3c3c 3e3e3e3e 3e3c3c3c >>>><<<<>>>>><<< - .*1010 3e3e3e3e 3e3e3c3c 3e3e3e3e 3e3e3e3c >>>>>><<>>>>>>>< - .*1020 3e3e3e3e 3c3c3c3c 3e3e3e3e 3e3c3c3c >>>><<<<>>>>><<< - .*1030 3e3e3e3e 3e3e3c3c 3e3e3e3e 3e3e3e3c >>>>>><<>>>>>>>< - .*1040 ffffffff ffffffff 00000000 00000000 ................ - .*1050 ffffffff ffffffff 00000000 00000000 ................ -Contents of section \.data: - .*2000 3e3e3e3e 3c3c3c3c 3e3e3e3e 3e3c3c3c >>>><<<<>>>>><<< - .*2010 3e3e3e3e 3e3e3c3c 3e3e3e3e 3e3e3e3c >>>>>><<>>>>>>>< - .*2020 3e3e3e3e 04000000 110d0000 00111600 >>>>............ - .*2030 0000111f 00000011 3c3c3c3c 3c3c3c3c ........<<<<<<<< - .*2040 3e3e3e3e 04000000 110d0000 00111600 >>>>............ - .*2050 0000111f 00000011 3c3c3c3c 3c3c3c3c ........<<<<<<<< - .*2060 3e3e3e3e 04000000 110d0000 00111600 >>>>............ - .*2070 0000111f 00000011 3c3c3c3c 3c3c3c3c ........<<<<<<<< - .*2080 3e3e3e3e 24000000 112d0000 00113600 >>>>\$....-....6. - .*2090 0000113f 00000011 3c3c3c3c 3c3c3c3c ...\?....<<<<<<<< -Contents of section \.rdata: - .*3000 3e3e3e3e 3c3c3c3c 3e3e3e3e 3e3c3c3c >>>><<<<>>>>><<< - .*3010 3e3e3e3e 3e3e3c3c 3e3e3e3e 3e3e3e3c >>>>>><<>>>>>>>< - .*3020 3e3e3e3e 00000000 00000000 00000000 >>>>............ -Contents of section \.idata: - .*4000 00000000 00000000 00000000 00000000 ................ - .*4010 00000000 .... + +tmpdir/secrel\.x: +file format pei-.* + +Contents of section \.text: + .*1000 3e3e3e3e 3c3c3c3c 3e3e3e3e 3e3c3c3c .* + .*1010 3e3e3e3e 3e3e3c3c 3e3e3e3e 3e3e3e3c .* + .*1020 3e3e3e3e 3c3c3c3c 3e3e3e3e 3e3c3c3c .* + .*1030 3e3e3e3e 3e3e3c3c 3e3e3e3e 3e3e3e3c .* + .*1040 ffffffff ffffffff 00000000 00000000 .* + .*1050 ffffffff ffffffff 00000000 00000000 .* +Contents of section \.data: + .*2000 3e3e3e3e 3c3c3c3c 3e3e3e3e 3e3c3c3c .* + .*2010 3e3e3e3e 3e3e3c3c 3e3e3e3e 3e3e3e3c .* + .*2020 3e3e3e3e 04000000 110d0000 00111600 .* + .*2030 0000111f 00000011 3c3c3c3c 3c3c3c3c .* + .*2040 3e3e3e3e 04000000 110d0000 00111600 .* + .*2050 0000111f 00000011 3c3c3c3c 3c3c3c3c .* + .*2060 3e3e3e3e 04000000 110d0000 00111600 .* + .*2070 0000111f 00000011 3c3c3c3c 3c3c3c3c .* + .*2080 3e3e3e3e 24000000 112d0000 00113600 .* + .*2090 0000113f 00000011 3c3c3c3c 3c3c3c3c .* +Contents of section \.rdata: + .*3000 3e3e3e3e 3c3c3c3c 3e3e3e3e 3e3c3c3c .* + .*3010 3e3e3e3e 3e3e3c3c 3e3e3e3e 3e3e3e3c .* + .*3020 3e3e3e3e 00000000 00000000 00000000 .* +Contents of section \.idata: + .*4000 00000000 00000000 00000000 00000000 .* + .*4010 00000000 00000000 .* -- Alan Modra Australia Development Lab, IBM