From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by sourceware.org (Postfix) with ESMTPS id A89AA3858C33 for ; Thu, 26 Jan 2023 21:53:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A89AA3858C33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x62d.google.com with SMTP id g23so3088423plq.12 for ; Thu, 26 Jan 2023 13:53:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=jbv1ppPesoo3gClkLSJoxl8COkHJ4YrfJ9Qlpe9n0TQ=; b=b0vh0dLLIcdIzSPXuJ9C8D7CsuqSh3SSVsO5+lBV84XIiAuVHfuCjeN1Yys/XWEUVI RrXgEJ4OZG8+VbK1Zssoy0NzbjFbCzjgnFX/5QjT3dJgL6i3izI1LLQ5B6gTt1KjpVbD wbdNvXZYhzOXnKPTnu6R9tIQ/Bh+an+JIpFRh4/LdkFJVECfpg4sJB6jqgCcwzp9q83P GSH+It84Wk2Mbn0okgYrYttg7WHAgJ/QZlLApv+yANfpRx5HOioOqCb5LHamukMjRGIv PDoCQSn6N0iUUYoHPKhSr9KTMAp7+OKlI5MyZKLxEMPGKEW8TJRVRSUk51CYkeJsSYeY QYKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jbv1ppPesoo3gClkLSJoxl8COkHJ4YrfJ9Qlpe9n0TQ=; b=m4mPBOOhbww2Xh6FKsFMbu7huC8TLMrnWeD/fi/PAt3NuFrRKUFJOefj7ImwyaRue9 CsyNVJJ6kWCn+nkacw9AHjXbz9GRIKAkNLq+xu74KHc9oA2gkuueaAeUZsV8JRKJKdPY 0dOasaQB+BrXglbqWNBCQ972TetLakNQ77VlvQ9YHYVHmJO5MztLyYEaXoKVRU9xgQgM oPeBgjRc2o8HcTbdKM2WUxou1Ou902mRFSV+LWezPDDI0wkBsysVWhdIMIiT2upRLdxt /l362VgpooKGHrLnHuuN9NbGlkd/6u0m3knL6Ts7t6bgm+ANN1PvNLC0wxFw0XCBMzBq PvKQ== X-Gm-Message-State: AFqh2koPH6s8HrX4OIPd/Is82s39QZfN/nQ5Xf2OqQfkbetRYofK+v+m NSVgQOXho1VpeEWt+8ZvG85whHlOxOo= X-Google-Smtp-Source: AMrXdXtdzMN3AJwvHfWdAaqKYx0hRX5UPEPb2UEznHCmH8NBmJuP7Df37jTk4QcFUiyYAm2kDF7Wsg== X-Received: by 2002:a17:902:b20d:b0:191:4389:f8f5 with SMTP id t13-20020a170902b20d00b001914389f8f5mr37613222plr.34.1674769981666; Thu, 26 Jan 2023 13:53:01 -0800 (PST) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id g17-20020a170902869100b00189c62eac37sm1453190plo.32.2023.01.26.13.53.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jan 2023 13:53:01 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 46F3B1142CC6; Fri, 27 Jan 2023 08:22:59 +1030 (ACDT) Date: Fri, 27 Jan 2023 08:22:59 +1030 From: Alan Modra To: binutils@sourceware.org Subject: Sanity check dwarf5 form of .file Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3035.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: There's a comment a few lines earlier saying that demand_copy_C_string has already reported an error if it returns NULL. Given the proximity I decided not to duplicate the comment. * dwarf2dbg.c (dwarf2_directive_filename): Check return of demand_copy_C_string for file. diff --git a/gas/dwarf2dbg.c b/gas/dwarf2dbg.c index 86dc16108e4..5f2f58ff7b0 100644 --- a/gas/dwarf2dbg.c +++ b/gas/dwarf2dbg.c @@ -1195,6 +1195,8 @@ dwarf2_directive_filename (void) { dirname = filename; filename = demand_copy_C_string (&filename_len); + if (filename == NULL) + return NULL; SKIP_WHITESPACE (); } -- Alan Modra Australia Development Lab, IBM