From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Subject: Call bfd_close_all_done in output_file_close
Date: Fri, 27 Jan 2023 17:31:17 +1030 [thread overview]
Message-ID: <Y9N2vclgJwnt0fbW@squeak.grove.modra.org> (raw)
bfd_cache_close_all is good for closing file descriptors, but doesn't
do the cleanup of bfd memory as in bfd_close_all_done.
PR 13056
* output-file.c (output_file_close): Call bfd_close_all_done,
not bfd_cache_close_all.
diff --git a/gas/output-file.c b/gas/output-file.c
index 4c97e8f1a9b..88f40116513 100644
--- a/gas/output-file.c
+++ b/gas/output-file.c
@@ -96,7 +96,7 @@ output_file_close (void)
/* Close the bfd. */
if (!flag_always_generate_output && had_errors ())
- res = bfd_cache_close_all ();
+ res = bfd_close_all_done (obfd);
else
res = bfd_close (obfd);
now_seg = NULL;
--
Alan Modra
Australia Development Lab, IBM
reply other threads:[~2023-01-27 7:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9N2vclgJwnt0fbW@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).