From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Subject: Silence ubsan warning about 1<<31
Date: Tue, 31 Jan 2023 15:22:16 +1030 [thread overview]
Message-ID: <Y9iegPmzz6ZQLXCO@squeak.grove.modra.org> (raw)
* merge.c (hash_blob): Write 1u << 31.
diff --git a/bfd/merge.c b/bfd/merge.c
index f21154dcd45..327bd66b341 100644
--- a/bfd/merge.c
+++ b/bfd/merge.c
@@ -279,7 +279,7 @@ hash_blob (const char *str, unsigned int len)
uint32_t ret = 0;
uint32_t mul = (1 << 0) + (1 << 2) + (1 << 3) + (1 << 5) + (1 << 7);
mul += (1 << 11) + (1 << 13) + (1 << 17) + (0 << 19) + (1 << 23) + (1 << 29);
- mul += (1 << 31);
+ mul += (1u << 31);
if (len >= 8)
{
uint32_t acc = len * 0x9e3779b1;
--
Alan Modra
Australia Development Lab, IBM
reply other threads:[~2023-01-31 4:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9iegPmzz6ZQLXCO@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).