From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Subject: Recursion in as_info_where
Date: Wed, 1 Feb 2023 17:06:54 +1030 [thread overview]
Message-ID: <Y9oIhhJR9qaUEmFI@squeak.grove.modra.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 706 bytes --]
This function has a gas_assert, ie. possible call to as_abort, which
calls as_report_context, which calls as_info_where. Attached fuzzer
testcase managed to trigger a stack overflow.
* messages.c (as_info_where): Don't gas_assert.
diff --git a/gas/messages.c b/gas/messages.c
index 0db075d779c..7c018acf69f 100644
--- a/gas/messages.c
+++ b/gas/messages.c
@@ -141,8 +141,6 @@ as_info_where (const char *file, unsigned int line, unsigned int indent,
va_list args;
char buffer[2000];
- gas_assert (file != NULL && line > 0 && indent <= INT_MAX);
-
va_start (args, format);
vsnprintf (buffer, sizeof (buffer), format, args);
va_end (args);
--
Alan Modra
Australia Development Lab, IBM
[-- Attachment #2: clusterfuzz-testcase-minimized-fuzz_as-5392730034667520 --]
[-- Type: application/octet-stream, Size: 26 bytes --]
next reply other threads:[~2023-02-01 6:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 6:36 Alan Modra [this message]
2023-02-01 9:24 ` Jan Beulich
2023-02-01 11:59 ` Alan Modra
2023-02-03 13:44 ` Jan Beulich
2023-02-06 1:41 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9oIhhJR9qaUEmFI@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).