From: Mike Frysinger <vapier@gentoo.org>
To: Tom Tromey <tom@tromey.com>
Cc: binutils@sourceware.org, gdb-patches@sourceware.org
Subject: Re: [PATCH] config/debuginfod: do not include pkg.m4 directly
Date: Sat, 13 Feb 2021 00:17:10 -0500 [thread overview]
Message-ID: <YCdg1l3B6AeW345l@vapier> (raw)
In-Reply-To: <87sg66fiwu.fsf@tromey.com>
On 08 Feb 2021 12:39, Tom Tromey wrote:
> >>>>> "Mike" == Mike Frysinger via Binutils <binutils@sourceware.org> writes:
>
> Mike> Any code using AC_DEBUGINFOD from this dir is using -I../config when
> Mike> running aclocal, so an explicit include on pkg.m4 is unnecessary:
> Mike> aclocal will find the pkg.m4 in this dir just as easily. This is
> Mike> seen in the only two dirs that use AC_DEBUGINFOD (binutils & gdb)
> Mike> as their aclocal.m4 already has m4_include on config m4 files.
>
> Mike> The include as written only works if aclocal is run on a dir that is
>
> Mike> config/
> Mike> * debuginfod.m4: Delete m4_include(../config/pkg.m4).
>
> Mike> binutils/
> Mike> * aclocal.m4: Regenerate.
>
> Mike> gdb/
> Mike> * aclocal.m4: Regenerate.
>
> This is fine by me, but please wait a little while in case someone on
> the binutils list has a differing opinion.
thanks, i've pushed now
-mike
prev parent reply other threads:[~2021-02-13 5:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-07 0:31 Mike Frysinger
2021-02-08 19:39 ` Tom Tromey
2021-02-13 5:17 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCdg1l3B6AeW345l@vapier \
--to=vapier@gentoo.org \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).