From: "H.J. Lu" <hjl.tools@gmail.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Binutils <binutils@sourceware.org>, "H.J. Lu" <hjl.tools@gmail.com>
Subject: Re: [PATCH 4/8] x86: split opcode prefix and opcode space representation
Date: Mon, 22 Mar 2021 11:04:09 -0700 [thread overview]
Message-ID: <YFjcGXV0asWB16Z8@gmail.com> (raw)
In-Reply-To: <f116024a-077d-c64e-f37c-1da8299272f0@suse.com>
On Mon, Mar 22, 2021 at 05:44:19PM +0100, Jan Beulich wrote:
> Commit 8b65b8953af2 ("x86: Remove the prefix byte from non-VEX/EVEX
> base_opcode") used the opcodeprefix field for two distinct purposes. In
> preparation of having VEX/XOP/EVEX and non-VEX templates become similar
> in the representatioon of both encoding space and opcode prefixes, split
> the field to have a separate one holding an insn's opcode space.
>
> gas/
> 2021-03-XX Jan Beulich <jbeulich@suse.com>
>
> * config/tc-i386.c (pte): Print prefix and encoding space.
> (build_vex_prefix): Check opcodespace instead of opcodeprefix.
> (build_evex_prefix): Likewise.
> (load_insn_p): Likewise.
>
> opcodes/
> 2021-03-XX Jan Beulich <jbeulich@suse.com>
>
> * i386-gen.c (opcode_modifiers): New OpcodeSpace element.
> * i386-opc.h (OpcodeSpace): New enumerator.
> (VEX0F, VEX0F38, VEX0F3A, XOP08, XOP09, XOP0A): Rename to ...
> (SPACE_BASE, SPACE_0F, SPACE_0F38, SPACE_0F3A, SPACE_XOP08,
> SPACE_XOP09, SPACE_XOP0A): ... respectively.
> (struct i386_opcode_modifier): New field opcodespace. Shrink
> opcodeprefix field.
> i386-opc.tbl (Space0F, Space0F38, Space0F3A, SpaceXOP08,
> SpaceXOP09, SpaceXOP0A): Define. Use them to replace
> OpcodePrefix uses.
> * i386-tbl.h: Re-generate.
>
OK. Thanks.
H.J.
prev parent reply other threads:[~2021-03-22 18:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 16:40 [PATCH 0/8] x86: work towards further opcode table compaction Jan Beulich
2021-03-22 16:42 ` [PATCH 1/8] x86: unbreak certain MPX insn operand forms Jan Beulich
2021-03-22 17:58 ` H.J. Lu
2021-03-22 16:42 ` [PATCH 2/8] x86: don't open-code PREFIX_NONE Jan Beulich
2021-03-22 17:58 ` H.J. Lu
2021-03-22 16:43 ` [PATCH 3/8] x86: don't use opcode_length to identify pseudo prefixes Jan Beulich
2021-03-22 17:55 ` H.J. Lu
2021-03-23 7:36 ` Jan Beulich
2021-03-23 12:05 ` H.J. Lu
2021-03-23 16:42 ` [PATCH v2] " Jan Beulich
2021-03-23 18:32 ` H.J. Lu
2021-03-22 16:44 ` [PATCH 5/8] x86: re-order two fields of struct insn_template Jan Beulich
2021-03-22 18:03 ` H.J. Lu
2021-03-22 16:45 ` [PATCH 6/8] x86: re-number PREFIX_0X<nn> Jan Beulich
2021-03-22 18:03 ` H.J. Lu
2021-03-22 16:46 ` [PATCH 7/8] x86: derive mandatory prefix attribute from base opcode Jan Beulich
2021-03-22 18:03 ` H.J. Lu
2021-03-23 16:36 ` Jan Beulich
2021-03-23 18:34 ` H.J. Lu
2021-03-24 7:27 ` Jan Beulich
2021-03-24 13:43 ` H.J. Lu
[not found] ` <65b17a6a-cc6a-a706-5e95-a7284c45beb1@suse.com>
2021-03-22 18:02 ` [PATCH 8/8] x86: derive opcode length from opcode value H.J. Lu
[not found] ` <f116024a-077d-c64e-f37c-1da8299272f0@suse.com>
2021-03-22 18:04 ` H.J. Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFjcGXV0asWB16Z8@gmail.com \
--to=hjl.tools@gmail.com \
--cc=binutils@sourceware.org \
--cc=jbeulich@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).