From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id E99823858004; Tue, 23 Mar 2021 04:49:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E99823858004 Received: from vapier (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 56AB633BEA7; Tue, 23 Mar 2021 04:49:11 +0000 (UTC) Date: Tue, 23 Mar 2021 00:49:10 -0400 From: Mike Frysinger To: Alan Modra Cc: Martin =?utf-8?B?TGnFoWth?= , Tom Tromey , Alan Modra via Binutils , gdb-patches@sourceware.org Subject: Re: [PATCH] Add startswith function and use it instead of CONST_STRNEQ. Message-ID: Mail-Followup-To: Alan Modra , Martin =?utf-8?B?TGnFoWth?= , Tom Tromey , Alan Modra via Binutils , gdb-patches@sourceware.org References: <20210319063759.GM6791@bubble.grove.modra.org> <20210320070037.GR6791@bubble.grove.modra.org> <87wnu1k5z1.fsf@tromey.com> <20210321131254.GS6791@bubble.grove.modra.org> <87k0q0j5ql.fsf@tromey.com> <20210322120652.GV6791@bubble.grove.modra.org> <20210323000245.GZ6791@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210323000245.GZ6791@bubble.grove.modra.org> X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Mar 2021 04:49:14 -0000 On 23 Mar 2021 10:32, Alan Modra wrote: > On Mon, Mar 22, 2021 at 05:42:50PM +0100, Martin Liška wrote: > > Anyway for the sim failures. What about directly including in bfd-in.h? > > That would be OK if we didn't care about really old systems. See for > example the way bfd/sysdep.h includes string.h. > > But all of this horrible old code that likely hasn't been tested is > eons should simply disappear. Instead binutils should be using the > gnulib import already available in the binutils-gdb repository to > support old systems. I've had that project on my todo list for quite > a while. We'd be able to include stdint.h and stdbool.h for example, > throwing away bfd_stdint.h and replacing bfd_boolean with bool. i agree with the idea that we've accumulated a lot of cruft that we never test and it's unclear how many users still rely on it. for the sim, i've made C11 a requirement inline with GDB's C++11 requirement. that means i can assume among other things. > Meanwhile, this is a tidied version of the patch I sent you last > night, Tom. If you already have one of your own then please ignore > this. this fixes the sim for me, thanks -mike