From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id E03F33844019 for ; Wed, 23 Jun 2021 01:11:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E03F33844019 Received: by mail-pf1-x431.google.com with SMTP id x16so924618pfa.13 for ; Tue, 22 Jun 2021 18:11:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=z2rZsu45MkuY32PcLIGGY3ksnLsWwgefBTjcPRrXxP0=; b=ubJ0Ap/LzSOtHcuv+vfX83gXOLvMyxwn+ywN3xgBDny0SlotV/umIooEvG42HKyk8e G3O7l8XadyioEHAQD4DWsn7Jd/JRrj9WY7hBUxqjjl3Z/uj57H43dbNp1VGRoNc6p6i/ Zq5JME4R/LTcWZaGgFH5eKbzOBAM2b7vfgCspxFwJggxQ4fjxiqgUNublm89qCTeQH8G BZzJk+l9MZDrkGv/Y9SRmuTT5BxXBwHySgPdhEZBxPNbrtp8dA1aCThEEwTWPua3+2Da /sZ4Jt2pX1i+3k29VjDLRq9HZZ60NdNtJr/shwZ8JBiYeHxGewPI+agbylzOBPkxlwZu i5+Q== X-Gm-Message-State: AOAM533c0m3PWCTcE7E6CxY9QjZT8CKnq5fhtZIx7ohJP5uap9nWdPH0 WYpFqoT7k1g/QZCQWUs6g4bWFzGkfZTVVQ== X-Google-Smtp-Source: ABdhPJx+6Dobt07W1Y9tXTqNNc6BPPWrfulPfCfC7fy7qnu6ivn9u5byYRRRUOz7lDCin6zmJS2PDw== X-Received: by 2002:a63:5d19:: with SMTP id r25mr1296838pgb.317.1624410719075; Tue, 22 Jun 2021 18:11:59 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id b126sm360419pfg.176.2021.06.22.18.11.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jun 2021 18:11:58 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 97CF51140026; Wed, 23 Jun 2021 10:41:54 +0930 (ACST) Date: Wed, 23 Jun 2021 10:41:54 +0930 From: Alan Modra To: "CHIGOT, CLEMENT" Cc: "binutils@sourceware.org" Subject: Re: [PATCH] gas: update csect alignment for PPC prefixed instructions on XCOFF Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-3033.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jun 2021 01:12:01 -0000 On Tue, Jun 22, 2021 at 11:19:30AM +0000, CHIGOT, CLEMENT via Binutils wrote: > --- a/gas/config/tc-ppc.c > +++ b/gas/config/tc-ppc.c > @@ -4039,6 +4039,10 @@ md_assemble (char *str) > boundaries. */ > frag_align_code (6, 4); > record_alignment (now_seg, 6); > +#ifdef OBJ_XCOFF > + /* Update alignment of the containing csect. */ > + symbol_get_tc (ppc_current_csect)->align = 6; > +#endif Is there a possibility that this might decrease alignment? If so, you should write: if (symbol_get_tc (ppc_current_csect)->align < 6) symbol_get_tc (ppc_current_csect)->align = 6; -- Alan Modra Australia Development Lab, IBM