From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by sourceware.org (Postfix) with ESMTPS id 653DE3894C1A for ; Thu, 24 Jun 2021 01:23:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 653DE3894C1A Received: by mail-pj1-x102f.google.com with SMTP id pf4-20020a17090b1d84b029016f6699c3f2so4893172pjb.0 for ; Wed, 23 Jun 2021 18:23:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=faJzt7HEo1un6N3bHm5qk9vu8e7VnUZJu3N7T97qL/A=; b=n2rd4IR2iBbeHmCHXGU/f20lYTyu4joCtADnfnfF0bxY7+SJMxjsYvc+NREc03V8qX km9Gj/XMJveLOMA8BLROT5R6CZmvR/bEAgAg6llIsviuDhicaP0N9EDwhQ7xPJZbj3CS IwBJrQDsZC33RERQa7CmX/JrvX/uQcQWyCkAnUHIHM4uLXVLxVaueb3JzAnkUgWLZUmF BkJsv5RsnnXk+BFy9/yJT1Xz6h13nKHxg2gK+OJA+qSy4iJzKM7yMfd8dVnoeTdcLiik iXLqjK6hPKjtBAyCe8EBKpWrHHLxaKNBMOdtdmahAdJwCVZ3iboVVL92gRucxkZisiWf R5Bw== X-Gm-Message-State: AOAM532Rcw9QJAKPus29Gbrwzilp4wYiwD4WQahV6bTFcNuVS+xyFztP kh5+LD/K5EGOsH9bGhQBBic= X-Google-Smtp-Source: ABdhPJx6wu4i78P8ogqG858ovKp3mvKUA8v36tAlnejc6rDUdQIwUc26xgx3SVySlUm3WtIP9aKzcA== X-Received: by 2002:a17:90a:1d0e:: with SMTP id c14mr12566331pjd.171.1624497787638; Wed, 23 Jun 2021 18:23:07 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:916:8bbf:8c01:56e0]) by smtp.gmail.com with ESMTPSA id d16sm6357031pjs.33.2021.06.23.18.23.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Jun 2021 18:23:06 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 2F3C4114000B; Thu, 24 Jun 2021 10:53:04 +0930 (ACST) Date: Thu, 24 Jun 2021 10:53:04 +0930 From: Alan Modra To: "CHIGOT, CLEMENT" Cc: "binutils@sourceware.org" Subject: Re: [PATCH] gas: update csect alignment for PPC prefixed instructions on XCOFF Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-3029.5 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jun 2021 01:23:09 -0000 On Wed, Jun 23, 2021 at 06:49:04AM +0000, CHIGOT, CLEMENT wrote: > >> +++ b/gas/config/tc-ppc.c > >> @@ -4039,6 +4039,10 @@ md_assemble (char *str) > >>         boundaries.  */ > >>        frag_align_code (6, 4); > >>        record_alignment (now_seg, 6); > >> +#ifdef OBJ_XCOFF > >> +      /* Update alignment of the containing csect.  */ > >> +      symbol_get_tc (ppc_current_csect)->align = 6; > >> +#endif > > > > Is there a possibility that this might decrease alignment?  If so, you > > should write: > > > >     if (symbol_get_tc (ppc_current_csect)->align < 6) > >        symbol_get_tc (ppc_current_csect)->align = 6; > > Any value can be passed for the alignment of csect. Thus, it might be > possible but I doubt it will ever happen. > Anyway I've updated the patch. OK, I've committed the patch for you. -- Alan Modra Australia Development Lab, IBM