* [PATCH] opcodes: d10v: simplify header includes
@ 2021-10-31 9:14 Mike Frysinger
2021-11-03 1:04 ` Alan Modra
0 siblings, 1 reply; 2+ messages in thread
From: Mike Frysinger @ 2021-10-31 9:14 UTC (permalink / raw)
To: binutils
This file doesn't use anything from bfd (sysdep.h), so drop that
include. This avoids an implicit dependency on the generated
config.h which can be problematic for build-time tools.
Also swap stdio.h for stddef.h. This file isn't doing or using
any I/O structures, but it does need NULL.
---
opcodes/d10v-opc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/opcodes/d10v-opc.c b/opcodes/d10v-opc.c
index c68fc6878a26..f87a0779b898 100644
--- a/opcodes/d10v-opc.c
+++ b/opcodes/d10v-opc.c
@@ -19,8 +19,7 @@
Software Foundation, 51 Franklin Street - Fifth Floor, Boston,
MA 02110-1301, USA. */
-#include "sysdep.h"
-#include <stdio.h>
+#include <stddef.h>
#include "opcode/d10v.h"
--
2.33.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] opcodes: d10v: simplify header includes
2021-10-31 9:14 [PATCH] opcodes: d10v: simplify header includes Mike Frysinger
@ 2021-11-03 1:04 ` Alan Modra
0 siblings, 0 replies; 2+ messages in thread
From: Alan Modra @ 2021-11-03 1:04 UTC (permalink / raw)
To: Mike Frysinger; +Cc: binutils
On Sun, Oct 31, 2021 at 05:14:12AM -0400, Mike Frysinger via Binutils wrote:
> This file doesn't use anything from bfd (sysdep.h), so drop that
> include. This avoids an implicit dependency on the generated
> config.h which can be problematic for build-time tools.
>
> Also swap stdio.h for stddef.h. This file isn't doing or using
> any I/O structures, but it does need NULL.
OK, thanks.
--
Alan Modra
Australia Development Lab, IBM
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-03 1:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-31 9:14 [PATCH] opcodes: d10v: simplify header includes Mike Frysinger
2021-11-03 1:04 ` Alan Modra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).