From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by sourceware.org (Postfix) with ESMTPS id 240A3385841F for ; Sat, 1 Jan 2022 05:18:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 240A3385841F Received: by mail-pj1-x1030.google.com with SMTP id v16so24833811pjn.1 for ; Fri, 31 Dec 2021 21:18:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition; bh=YrdFBhBD0xcg7CYT2SbLuKGlMmrZAHFgsHOsO2MBeO0=; b=u5ztOhlbP78W1lmaKnToXbbO/KhrzFWo0HAd+R5c/k0seex6/UB+lFMq2352fJ97sZ bdkw/IybBBBAxFUioGQY7YKvBAgzCAlT2OVedg3+ikcVRTrcXuw2n7CYtVVmAs0ZCQag Oego7Xb7olZ/KpD7gITPc0cR1xJqiv8qKaK28JNHocJqLeA3rRTyojQ6hRu98ha6it6E N0IKWtjEaahaBgWAy8xoEkCjomK9l2kX3E3QyZqUMNtO7ZNoI5SNyvKqEdA67zwIJBkh RLgBMqYfS1zQvIj1T0idWxLyBKM5P0DzAvaT60E6mowy3Q/a0TcrWTPBkRXCn0TmcVHn nmsw== X-Gm-Message-State: AOAM530s41QnRg1WRJabrXlcEF3hIdQd15pTgO2yOMH1ezcRXWbV93IS 5DQcA8pFDYgZCAEhcKzNdIe0DR5gxFA= X-Google-Smtp-Source: ABdhPJzk/U97t7gKJkeiT7F5q6Z1VDhfw3Vq15sKMpAujBoGfPEmzAxFZH9cGQADNByoyUnYjxCmag== X-Received: by 2002:a17:90b:4b41:: with SMTP id mi1mr34685941pjb.213.1641014324988; Fri, 31 Dec 2021 21:18:44 -0800 (PST) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id e21sm14763055pff.24.2021.12.31.21.18.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Dec 2021 21:18:44 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id CD4001142F93; Sat, 1 Jan 2022 15:48:41 +1030 (ACDT) Date: Sat, 1 Jan 2022 15:48:41 +1030 From: Alan Modra To: binutils@sourceware.org Subject: ubsan: bfd_mach_o_build_commands shift exponent 64 is too large Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3038.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Jan 2022 05:18:47 -0000 * mach-o.c (bfd_mach_o_read_section_32): Limit alignment further. (bfd_mach_o_read_section_64): Likewise. diff --git a/bfd/mach-o.c b/bfd/mach-o.c index d90ea3c28ce..af5ce024a0f 100644 --- a/bfd/mach-o.c +++ b/bfd/mach-o.c @@ -3653,12 +3653,12 @@ bfd_mach_o_read_section_32 (bfd *abfd, unsigned long prot) section->offset = bfd_h_get_32 (abfd, raw.offset); section->align = bfd_h_get_32 (abfd, raw.align); /* PR 17512: file: 0017eb76. */ - if (section->align > 64) + if (section->align >= 31) { _bfd_error_handler - (_("bfd_mach_o_read_section_32: overlarge alignment value: %#lx, " - "using 32 instead"), section->align); - section->align = 32; + (_("bfd_mach_o_read_section_32: overlarge alignment value: %#lx"), + section->align); + section->align = 30; } section->reloff = bfd_h_get_32 (abfd, raw.reloff); section->nreloc = bfd_h_get_32 (abfd, raw.nreloc); @@ -3696,12 +3696,12 @@ bfd_mach_o_read_section_64 (bfd *abfd, unsigned long prot) section->size = bfd_h_get_64 (abfd, raw.size); section->offset = bfd_h_get_32 (abfd, raw.offset); section->align = bfd_h_get_32 (abfd, raw.align); - if (section->align > 64) + if (section->align >= 63) { _bfd_error_handler - (_("bfd_mach_o_read_section_64: overlarge alignment value: %#lx, " - "using 32 instead"), section->align); - section->align = 32; + (_("bfd_mach_o_read_section_64: overlarge alignment value: %#lx"), + section->align); + section->align = 62; } section->reloff = bfd_h_get_32 (abfd, raw.reloff); section->nreloc = bfd_h_get_32 (abfd, raw.nreloc); -- Alan Modra Australia Development Lab, IBM