From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by sourceware.org (Postfix) with ESMTPS id A7B24385800A for ; Thu, 30 Dec 2021 07:57:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A7B24385800A Received: by mail-pj1-x102b.google.com with SMTP id z9-20020a17090a7b8900b001b13558eadaso27235068pjc.4 for ; Wed, 29 Dec 2021 23:57:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YM4QSrLP3efpRHKEHpKGiEyiFiPBgfOr08r2YFIewe4=; b=ErqLXbqgmdaAU+wiMCDN+6Zq+92zwEcZxIPOivjQRNYYMaG5ZaymyXvUuVm/u1pBTA Ca5LJeAxd7qiYS2B0v7pp+f8XpEFBfdSkzKC7SHVeJhVpEOWemYBwOZTYZb8TgOPZqUQ QFJc+9HItnoVN9xme6b0hfI0+BDO65akiNlhDelnXEyRJAYp7zn8ah+JKoQbe3QNFL45 g8AqDfJd5PQYzO8rJR4xQUV1XyFfrLkg+1vF+DbNFSA6IaC0VYR1jykzHlEnwrzjQ3Dq xymQk1ewmBPsrDokzSk6VM1iLktaiLBdVa2CYh86hYadLuXz8h9mJHMe4Cr4xEnGuTVO DESA== X-Gm-Message-State: AOAM533M1L63Qq07kwTMCOpq3zcSyGE4aE7P/qy8uSDw+ROppEi1xq1S hLOqB9w+e7nGdS/+wltH2fVpdgh6OEQ= X-Google-Smtp-Source: ABdhPJydkDl2/bb89o2lXgoG74CRJNmJo751zW/BqxvXdaPcENHkpkHGzbxgfvYEW+w69OHywn6zqA== X-Received: by 2002:a17:902:ec8c:b0:149:4910:e517 with SMTP id x12-20020a170902ec8c00b001494910e517mr30473526plg.123.1640851072605; Wed, 29 Dec 2021 23:57:52 -0800 (PST) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id u2sm24236093pjc.23.2021.12.29.23.57.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Dec 2021 23:57:52 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 076A811403A9; Thu, 30 Dec 2021 18:27:49 +1030 (ACDT) Date: Thu, 30 Dec 2021 18:27:49 +1030 From: Alan Modra To: Andi Kleen Cc: binutils@sourceware.org Subject: Re: [PATCH] Support symbol+offset lookup in addr2line Message-ID: References: <20211223175507.8506-1-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211223175507.8506-1-andi@firstfloor.org> X-Spam-Status: No, score=-3032.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Dec 2021 07:57:55 -0000 On Thu, Dec 23, 2021 at 09:55:07AM -0800, Andi Kleen wrote: > This patch implements the necessary steps directly in addr2line, > by looking up the symbol (with demangling if needed) and computing > the offset. Looks OK to me. -- Alan Modra Australia Development Lab, IBM