From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by sourceware.org (Postfix) with ESMTPS id 96C693858C3A for ; Tue, 11 Jan 2022 05:08:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 96C693858C3A Received: by mail-pj1-x102b.google.com with SMTP id y16-20020a17090a6c9000b001b13ffaa625so2933148pjj.2 for ; Mon, 10 Jan 2022 21:08:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+JawQmRNR/lI+JWWhtQnIQIztDbArg8c/vBRC9mafl8=; b=QgI4dXPjDGJeFzrxo9C9LP4offAYiW0z/q75O/KjkVSHZcwUtoj5+emGLan/G+HFbs UCf86Ky04U0KELMgG9TgGW+MFA3iZIt4qOY1rOMHOw94meUrX1HAFgKqUNGrKNCLYpcl Bjmb0YUByzX6o2EfXoUwa5DOKcllAaJTvggYFbvHFGaiZz55h4sXydcZnf3ULUmj5Wak 8qL7SIw2dZ3kKaCAydfy64MjBjT9gIpNcfkxjVsXce11W/f2g/YzozMbD39vzygz1tg5 cEmrHS64naawuKPVIDie8mQvXbtEXk5fzK1Jx6QlB5eCD1IvYxBd3wBvJriu6gXycSRf V8Ew== X-Gm-Message-State: AOAM5310raCcbbHfIljJR2+gchHa7VjNiuYTjfIGGgCvteraRRRnrqTz RTgdKNQJPvePdbneCvifhosDv6jLM7c= X-Google-Smtp-Source: ABdhPJx6IDm2bT/VLBaFKUAytd8lgoDX7EnxjppVTP5Jx6IUtzk5mtamKw+xoPWP9TUWX+rpxUKfjQ== X-Received: by 2002:a17:90b:4f90:: with SMTP id qe16mr1332001pjb.194.1641877723718; Mon, 10 Jan 2022 21:08:43 -0800 (PST) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id s13sm3575055pgm.33.2022.01.10.21.08.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jan 2022 21:08:42 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 076BD11403FE; Tue, 11 Jan 2022 15:38:40 +1030 (ACDT) Date: Tue, 11 Jan 2022 15:38:40 +1030 From: Alan Modra To: "H.J. Lu" Cc: Nick Clifton , Binutils Subject: Re: 2.38 branch date approaching Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-3032.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jan 2022 05:08:46 -0000 On Mon, Jan 10, 2022 at 08:20:13AM -0800, H.J. Lu via Binutils wrote: > Hi Nick, > > Can you review my DT_RELR patches? > > https://sourceware.org/pipermail/binutils/2022-January/119222.html I've looked over them. I keep asking myself, "Why did HJ have to reinvent everything rather than reuse existing code used in other targets?" And "Why do we need yet another hook?" All of which will be a maintenance burden, especially after you retire or quit binutils work for any other reason. You'll need to justify design decisions, and not assume other targets will follow your design. This sort of thing + /* NB: Also enable relaxation to layout sections for DT_RELR. */ + if (RELAXATION_ENABLED || link_info.enable_dt_relr) is just wrong. There is absolutely no fundamental reason that bfd_relax_section must handle sizing of the DT_RELR section. I choose to not do so on powerpc64. -- Alan Modra Australia Development Lab, IBM