From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 5E8233858C39 for ; Sun, 23 Jan 2022 17:42:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5E8233858C39 Received: by smtp.gentoo.org (Postfix, from userid 559) id 73A3B342E04; Sun, 23 Jan 2022 17:42:58 +0000 (UTC) Date: Sun, 23 Jan 2022 12:43:01 -0500 From: Mike Frysinger To: "H.J. Lu" Cc: binutils@sourceware.org Subject: Re: [PATCH] bfd: Properly install library and header files Message-ID: Mail-Followup-To: "H.J. Lu" , binutils@sourceware.org References: <20220123153652.1130563-1-hjl.tools@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JBEgOF/Ztc2QYRAO" Content-Disposition: inline In-Reply-To: <20220123153652.1130563-1-hjl.tools@gmail.com> X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Jan 2022 17:43:01 -0000 --JBEgOF/Ztc2QYRAO Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On 23 Jan 2022 07:36, H.J. Lu via Binutils wrote: > Rename bfdlib_LTLIBRARIES and bfdinclude_HEADERS to lib_LTLIBRARIES and > include_HEADERS to fix the missing installed library and header files in > bfd caused by your patch below does two things: renames the vars and deletes an install target. pretty sure only the latter is necessary to fix things. although i don't know the history behind why bfd uses these names. > --- a/bfd/Makefile.am > +++ b/bfd/Makefile.am > @@ -36,14 +36,14 @@ libbfd_la_LDFLAGS = > if INSTALL_LIBBFD > bfdlibdir = @bfdlibdir@ > bfdincludedir = @bfdincludedir@ > -bfdlib_LTLIBRARIES = libbfd.la > -bfdinclude_HEADERS = $(BFD_H) $(INCDIR)/ansidecl.h $(INCDIR)/symcat.h \ > - $(INCDIR)/diagnostics.h $(INCDIR)/bfdlink.h > +lib_LTLIBRARIES = libbfd.la > +include_HEADERS = $(BFD_H) $(INCDIR)/ansidecl.h $(INCDIR)/symcat.h \ > + $(INCDIR)/diagnostics.h $(INCDIR)/bfdlink.h > else !INSTALL_LIBBFD > # Empty these so that the respective installation directories will not be created. > bfdlibdir = > bfdincludedir = > -bfdinclude_HEADERS = > +include_HEADERS = > rpath_bfdlibdir = @bfdlibdir@ > noinst_LTLIBRARIES = libbfd.la > libbfd_la_LDFLAGS += -rpath $(rpath_bfdlibdir) there's stale comments in here now, as well as unused vars. the only reason bfdincludedir was defined was because bfdinclude_HEADERS was too. i think you should revert the bfd/Makefile.am changes and only keep the fix to doc/local.mk. -mike --JBEgOF/Ztc2QYRAO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmHtk6UACgkQQWM7n+g3 9YFSGw/+OSy9ziluXLwPPvUqfjF0uMMHRScu7o4Ep5re3KY+Afv+SVrfUKAWjPs6 6NBvLVXdwlTtgHKDam/X/cb+TUvlnLqjXWw0zJzaKeJYOa1w0QmE+YVicODroEHX /Z9hsFZpuOBoY/TTlRntaj/P6mz6/xM9zsWueWVk4ZoAjO7lLIqL8RTO2/BxOPRb CXhouIHqd7Lw6dpuXHaSbC6+oiNJXb+JH5ZzMh6UWBjnZ7jSzhwGzsJifb7N2Daq Hd7zP0vPVSzATfnQNtev3OJ5YlrIMdmjT+OBv4S0DT/UAnR9+WYamNQA0YtfTlsj r1K3dD0BJMsRjEEV7EtCx5b9hstxEp6HfnqWgnrjAvOZ2c7mWtuysdNvLYRbyPe/ v+oUHCdXeoKPmFBhJQrDphO8cBiPzwuZMt9OSkHZKkfdmecy1VFUCLut8ghz97IC N6gEGJkKeKWBLGHKlT5DKa/IpUj6m2hGPkqDHjdQNSVJbwt3gW6MVVA299EAnT5G mHSd4xVIvChMir39qADyVs2Gnj0app6JoGnc7jl+k8Sx/IW3C5Fv1LEcfHTXxlma 57cukCDvn6cAm+txAx/bUrwHn1j6XOyrToyvkxZ00hWYMH3pDz/tx6pBPxcFOISV OaL8+Nmhyrc/Hs303+f5aeXqHHKPPwQiQoanx3wktUk+bQ90nLA= =+Hxz -----END PGP SIGNATURE----- --JBEgOF/Ztc2QYRAO--