From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hall.aurel32.net (hall.aurel32.net [IPv6:2001:bc8:30d7:100::1]) by sourceware.org (Postfix) with ESMTPS id 59C333858D1E for ; Sun, 6 Feb 2022 12:26:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 59C333858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=aurel32.net Authentication-Results: sourceware.org; spf=none smtp.mailfrom=aurel32.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=aurel32.net ; s=202004.hall; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Content-Transfer-Encoding:From:Reply-To: Subject:Content-ID:Content-Description:X-Debbugs-Cc; bh=kq3OqQX8fQEyycDeJguwkwZ2ISZH6fxIKiGN/OfiW6A=; b=cSf/jYEh9JpMC6XxAYR16L23St MwG7GQMwf3A7X7Qjzg5LklHz6szkUBGO1NTj+UZhFDqk5w96b82DY2TfvOEREZcU5vgGSka5N5fLS pdflU6F9UCAd8Cpqwshsr2Eo3WbQW7VcVPMDOg4Ij3hnFOjJpovQleq+EkABNilFyBN7MuHCBaKU4 HCtomYdZqBLTow74FtkdEi3TFNvdaail19WS1Te0dq/LYUmhmHCfr6nIOmlD3U4KtCjISlxgAIssn PT703ZGszUyErs8baAyuR1oUA2RTQrXiSkbyvJ4wxsSucVNeJYovEZdgrjz8xQB7J4cw7ELdnhxGv vBTq936w==; Received: from [2a01:e34:ec5d:a741:8a4c:7c4e:dc4c:1787] (helo=ohm.rr44.fr) by hall.aurel32.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nGgcj-006l5Y-Jq; Sun, 06 Feb 2022 13:26:33 +0100 Received: from aurel32 by ohm.rr44.fr with local (Exim 4.95) (envelope-from ) id 1nGgcj-00HWgl-4s; Sun, 06 Feb 2022 13:26:33 +0100 Date: Sun, 6 Feb 2022 13:26:33 +0100 From: Aurelien Jarno To: Nelson Chu Cc: binutils@sourceware.org, jim.wilson.gcc@gmail.com, kito.cheng@sifive.com, palmer@dabbelt.com, andrew@sifive.com Subject: Re: [PATCH 1/2] RISC-V: Don't report mismatch warnings when versions are larger than 1.0. Message-ID: Mail-Followup-To: Nelson Chu , binutils@sourceware.org, jim.wilson.gcc@gmail.com, kito.cheng@sifive.com, palmer@dabbelt.com, andrew@sifive.com References: <1640880028-16820-1-git-send-email-nelson.chu@sifive.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1640880028-16820-1-git-send-email-nelson.chu@sifive.com> User-Agent: Mutt/2.1.4 (2021-12-11) X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Feb 2022 12:26:39 -0000 Hi, On 2021-12-30 08:00, Nelson Chu wrote: > In general, the extension is ratified when it's version is 1.0, that means > the versions larger than 1.0 should be compatible. Therefore, report the > mismatch warnings for these compatible versions seems redundant and a little > bit annoying. I know that there are some exceptions like zba 0.93 and e 1.9, > but we could handle them specially in the future patches. > > bfd/ > * elfnn-riscv.c (riscv_version_mismatch): Do not report the mismatch > warnings when versions are larger than 1.0. > ld/ > * testsuite/ld-riscv-elf/attr-merge-arch-failed-01.d: Removed. > * testsuite/ld-riscv-elf/attr-merge-arch-failed-01a.s: Removed. > * testsuite/ld-riscv-elf/attr-merge-arch-failed-01b.s: Removed. > * testsuite/ld-riscv-elf/attr-merge-arch-failed-ratified.d: Updated > and renamed from attr-merge-arch-failed-02a testcase. > * testsuite/ld-riscv-elf/attr-merge-arch-failed-ratified-a.s: Likewise. > * testsuite/ld-riscv-elf/attr-merge-arch-failed-ratified-b.s: Likewise. > * testsuite/ld-riscv-elf/attr-merge-arch-failed-ratified-c.s: Likewise. > * testsuite/ld-riscv-elf/attr-merge-arch-failed-ratified-d.s: Likewise. > * testsuite/ld-riscv-elf/ld-riscv-elf.exp: Updated. > --- > bfd/elfnn-riscv.c | 12 ++++++---- > .../ld-riscv-elf/attr-merge-arch-failed-01.d | 11 --------- > .../ld-riscv-elf/attr-merge-arch-failed-01a.s | 1 - > .../ld-riscv-elf/attr-merge-arch-failed-01b.s | 1 - > .../ld-riscv-elf/attr-merge-arch-failed-02.d | 27 ---------------------- > .../ld-riscv-elf/attr-merge-arch-failed-02a.s | 1 - > .../ld-riscv-elf/attr-merge-arch-failed-02b.s | 1 - > .../ld-riscv-elf/attr-merge-arch-failed-02c.s | 1 - > .../ld-riscv-elf/attr-merge-arch-failed-02d.s | 1 - > .../attr-merge-arch-failed-ratified-a.s | 1 + > .../attr-merge-arch-failed-ratified-b.s | 1 + > .../attr-merge-arch-failed-ratified-c.s | 1 + > .../attr-merge-arch-failed-ratified-d.s | 1 + > .../ld-riscv-elf/attr-merge-arch-failed-ratified.d | 22 ++++++++++++++++++ > ld/testsuite/ld-riscv-elf/ld-riscv-elf.exp | 3 +-- > 15 files changed, 35 insertions(+), 50 deletions(-) > delete mode 100644 ld/testsuite/ld-riscv-elf/attr-merge-arch-failed-01.d > delete mode 100644 ld/testsuite/ld-riscv-elf/attr-merge-arch-failed-01a.s > delete mode 100644 ld/testsuite/ld-riscv-elf/attr-merge-arch-failed-01b.s > delete mode 100644 ld/testsuite/ld-riscv-elf/attr-merge-arch-failed-02.d > delete mode 100644 ld/testsuite/ld-riscv-elf/attr-merge-arch-failed-02a.s > delete mode 100644 ld/testsuite/ld-riscv-elf/attr-merge-arch-failed-02b.s > delete mode 100644 ld/testsuite/ld-riscv-elf/attr-merge-arch-failed-02c.s > delete mode 100644 ld/testsuite/ld-riscv-elf/attr-merge-arch-failed-02d.s > create mode 100644 ld/testsuite/ld-riscv-elf/attr-merge-arch-failed-ratified-a.s > create mode 100644 ld/testsuite/ld-riscv-elf/attr-merge-arch-failed-ratified-b.s > create mode 100644 ld/testsuite/ld-riscv-elf/attr-merge-arch-failed-ratified-c.s > create mode 100644 ld/testsuite/ld-riscv-elf/attr-merge-arch-failed-ratified-d.s > create mode 100644 ld/testsuite/ld-riscv-elf/attr-merge-arch-failed-ratified.d Any reason why this patch hasn't been merged yet? Those warnings are causing many issues, for instance it adds dozen of thousands of failures to the gcc testsuite, even when binutils is configured with --with-isa-spec=2.2: | FAIL: gcc.target/riscv/pr84660.c (test for excess errors) | Excess errors: | /usr/bin/riscv64-linux-gnu-ld: warning: /build/gcc-9-WXLb8U/gcc-9-9.4.0/build/gcc/crti.o: mis-matched ISA version 2.0 for 'i' extension, the output version is 2.1 | /usr/bin/riscv64-linux-gnu-ld: warning: /build/gcc-9-WXLb8U/gcc-9-9.4.0/build/gcc/crti.o: mis-matched ISA version 2.0 for 'a' extension, the output version is 2.1 | /usr/bin/riscv64-linux-gnu-ld: warning: /build/gcc-9-WXLb8U/gcc-9-9.4.0/build/gcc/crti.o: mis-matched ISA version 2.0 for 'f' extension, the output version is 2.2 | /usr/bin/riscv64-linux-gnu-ld: warning: /build/gcc-9-WXLb8U/gcc-9-9.4.0/build/gcc/crti.o: mis-matched ISA version 2.0 for 'd' extension, the output version is 2.2 | /usr/bin/riscv64-linux-gnu-ld: warning: /build/gcc-9-WXLb8U/gcc-9-9.4.0/build/gcc/crtbeginS.o: mis-matched ISA version 2.0 for 'i' extension, the output version is 2.1 | /usr/bin/riscv64-linux-gnu-ld: warning: /build/gcc-9-WXLb8U/gcc-9-9.4.0/build/gcc/crtbeginS.o: mis-matched ISA version 2.0 for 'a' extension, the output version is 2.1 | /usr/bin/riscv64-linux-gnu-ld: warning: /build/gcc-9-WXLb8U/gcc-9-9.4.0/build/gcc/crtbeginS.o: mis-matched ISA version 2.0 for 'f' extension, the output version is 2.2 | /usr/bin/riscv64-linux-gnu-ld: warning: /build/gcc-9-WXLb8U/gcc-9-9.4.0/build/gcc/crtbeginS.o: mis-matched ISA version 2.0 for 'd' extension, the output version is 2.2 | /usr/bin/riscv64-linux-gnu-ld: warning: /tmp/cczGxSZh.o: mis-matched ISA version 2.0 for 'i' extension, the output version is 2.1 | /usr/bin/riscv64-linux-gnu-ld: warning: /tmp/cczGxSZh.o: mis-matched ISA version 2.0 for 'a' extension, the output version is 2.1 | /usr/bin/riscv64-linux-gnu-ld: warning: /tmp/cczGxSZh.o: mis-matched ISA version 2.0 for 'f' extension, the output version is 2.2 | /usr/bin/riscv64-linux-gnu-ld: warning: /tmp/cczGxSZh.o: mis-matched ISA version 2.0 for 'd' extension, the output version is 2.2 | /usr/bin/riscv64-linux-gnu-ld: warning: /build/gcc-9-WXLb8U/gcc-9-9.4.0/build/gcc/crtendS.o: mis-matched ISA version 2.0 for 'i' extension, the output version is 2.1 | /usr/bin/riscv64-linux-gnu-ld: warning: /build/gcc-9-WXLb8U/gcc-9-9.4.0/build/gcc/crtendS.o: mis-matched ISA version 2.0 for 'a' extension, the output version is 2.1 | /usr/bin/riscv64-linux-gnu-ld: warning: /build/gcc-9-WXLb8U/gcc-9-9.4.0/build/gcc/crtendS.o: mis-matched ISA version 2.0 for 'f' extension, the output version is 2.2 | /usr/bin/riscv64-linux-gnu-ld: warning: /build/gcc-9-WXLb8U/gcc-9-9.4.0/build/gcc/crtendS.o: mis-matched ISA version 2.0 for 'd' extension, the output version is 2.2 | /usr/bin/riscv64-linux-gnu-ld: warning: /build/gcc-9-WXLb8U/gcc-9-9.4.0/build/gcc/crtn.o: mis-matched ISA version 2.0 for 'i' extension, the output version is 2.1 | /usr/bin/riscv64-linux-gnu-ld: warning: /build/gcc-9-WXLb8U/gcc-9-9.4.0/build/gcc/crtn.o: mis-matched ISA version 2.0 for 'a' extension, the output version is 2.1 | /usr/bin/riscv64-linux-gnu-ld: warning: /build/gcc-9-WXLb8U/gcc-9-9.4.0/build/gcc/crtn.o: mis-matched ISA version 2.0 for 'f' extension, the output version is 2.2 | /usr/bin/riscv64-linux-gnu-ld: warning: /build/gcc-9-WXLb8U/gcc-9-9.4.0/build/gcc/crtn.o: mis-matched ISA version 2.0 for 'd' extension, the output version is 2.2 Thanks, Aurelien -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net