From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by sourceware.org (Postfix) with ESMTPS id 4EE973858D20 for ; Thu, 27 Jan 2022 00:48:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4EE973858D20 Received: by mail-pg1-x529.google.com with SMTP id t32so815442pgm.7 for ; Wed, 26 Jan 2022 16:48:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9mmpsSWmAZ+X4DGUVPOFC2zYfg4nbUt9P3yczuvutrI=; b=zXwZkDo6dYeLibSKr9u7rHc9SdtGwvZP/fAl/ksLCGyuo5o0FEpWfV1wB30WpLuu5g tK6j8vhANG0EspDMkS2YE+M68MGh/fFs9zB8Esjrg35dqyqpU+yEp6L8IzyfrIFD6o8M qUBxCCr4g27vm1tKqV7M2pZbGI8wg6Ce1BofQF1WcIQvQIf6zAFGQILISf7+WCNPQNjK x8CMnG5CctvskxvoUdyUOC4ItFFF+Cw0KgC8i9tU5ODy1351mLUwX+mMGr7PaK4CsSqb lU6h7PpRG+A9GhiRFdhsK+SaiTE4Jhp22P9yX5ZVnByvaRaYGofX6qN8lR5bxd32NHDO ITTQ== X-Gm-Message-State: AOAM533/RlxI24zhZKTZaxfWx2I85fN3i86yZx3BkiyFWoGudynZz2bh ewqy4QeG47cFyo2UvxsMzXKmlv+GyiA= X-Google-Smtp-Source: ABdhPJwdU9iSs5D1nWFJAMttHUQThbYz5Gq+eCBXTXVSnMNijfVe5TQkvvPXZT26K+kdjvrD6fZp6Q== X-Received: by 2002:a05:6a00:23d3:: with SMTP id g19mr921268pfc.27.1643244496368; Wed, 26 Jan 2022 16:48:16 -0800 (PST) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:708d:7cd7:24da:a693]) by smtp.gmail.com with ESMTPSA id a4sm376717pjs.24.2022.01.26.16.48.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jan 2022 16:48:15 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id A12851141215; Thu, 27 Jan 2022 11:18:12 +1030 (ACDT) Date: Thu, 27 Jan 2022 11:18:12 +1030 From: Alan Modra To: Nick Clifton Cc: "H.J. Lu" , Binutils Subject: Re: [PATCH v4] ld: Rewrite lang_size_relro_segment_1 Message-ID: References: <5448901b-167d-4423-c99e-557d8178e56d@redhat.com> <63e7ccbb-a69e-f38e-6e36-778b5fd39ad5@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <63e7ccbb-a69e-f38e-6e36-778b5fd39ad5@redhat.com> X-Spam-Status: No, score=-3029.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Jan 2022 00:48:18 -0000 On Wed, Jan 26, 2022 at 10:55:35AM +0000, Nick Clifton via Binutils wrote: > Hi H.J. > > > Here is the v4 patch to align the PT_GNU_RELRO segment first and subtract > > the maximum page size if therer is still a 1-page gap. This fixes: > > > > https://sourceware.org/bugzilla/show_bug.cgi?id=28819 > > Looks good to me. Please apply. Branch and mainline. How was this patch tested? If it has not been tested on targets other than x86 then it is not appropriate for the branch. Instead, I believe commit 2f83249c13d ought to be reverted on the branch. A wasted page in memory layout is not an important problem. We have more serious relro issues on targets other than x86. See pr28824. I'm speaking up because I raised concerns over the design of the previous patch, not just the implementation, and had those concerns overridden by Nick. Or possibly Nick didn't see my email before the previous patch was approved. Regardless of how it happened, I fear we might have even worse relro support in 2.38. FWIW, I also think that any fix I might develop for pr28824 will likely not be release branch quality until is has been tested for some time on mainline. -- Alan Modra Australia Development Lab, IBM