From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by sourceware.org (Postfix) with ESMTPS id 976E43858D1E for ; Wed, 9 Feb 2022 01:09:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 976E43858D1E Received: by mail-pl1-x630.google.com with SMTP id x4so844708plb.4 for ; Tue, 08 Feb 2022 17:09:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AdRI+gcRcZ/x0qlzdRb0Y+Mn3YG1DIMZKeSBtm19zMQ=; b=PP+yE297qaVFvOOGVnqT8E/GpAhMarCwjVcrveR0L1H+fbYJ0kOZnAm1vzMx9g610B ukgOhyQtjFCoQqkez5Es63DQErjq3MBhHEzyKN4kuVIz8Oo0YwAVA+2KAvx+YuX9+o1R MMH/gzlnNTtNeTlWwVTELNaFZthcbypND72Q2wlwCxxeSgOPNnPix059pal/3u8t/h3+ QqEHRhEqK2wXFj8Lh460IUAdxTUDa3uSdSQRWEXCnJGKFKNDxTctU6N1A/RTCvpoqWwN KoRC91IV2Pl9FikHkpuCzaxUR6IGjQYVyhfBI78S30W85IczeiYIIW71QUATCF1K1L+H vAPQ== X-Gm-Message-State: AOAM5332r2ZOhrcrneG2DcqUMETzlgHCnWyGqOLwlAXGStUprfE0VxPc NW44PgFCwmgon/6TGnig4Wpcu17AckQ= X-Google-Smtp-Source: ABdhPJz2ny79SIe4LVV5pMwypatZ4OzoGDsbA6FihlscVlCXHBjoY2iNDYCCHa6yItSPgqMWwiEJHg== X-Received: by 2002:a17:902:ed82:: with SMTP id e2mr6887458plj.55.1644368953744; Tue, 08 Feb 2022 17:09:13 -0800 (PST) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id oa5sm4286079pjb.0.2022.02.08.17.09.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Feb 2022 17:09:12 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 47FE211403A7; Wed, 9 Feb 2022 11:39:10 +1030 (ACDT) Date: Wed, 9 Feb 2022 11:39:10 +1030 From: Alan Modra To: Alexander Lindsay Cc: binutils@sourceware.org Subject: Re: Noted slowness in profile loading with binutils 2.37 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-3031.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Feb 2022 01:09:16 -0000 On Tue, Feb 08, 2022 at 09:44:58AM -0800, Alexander Lindsay via Binutils wrote: > Hi all, > > I recently experienced a slow-down in profile loading by the tool pprof, > and I believe I've boiled it down to changing from previous versions of > binutils to binutils version 2.37. Timings of profile loading are > documented on the pprof ticket I originally opened here: > https://github.com/google/pprof/issues/680#issuecomment-1032174210. I > reproduce them below: > > - binutils version 2.29.1: 1.1 seconds > - binutils version 2.33.1: 1.1 seconds > - binutils version 2.35.2: 6.8 seconds > - binutils version 2.36.1: 6.5 seconds > - binutils version 2.37: Still not loaded at 6 minutes > > I think the relevant binutil tool here is addr2line. Does anyone have a > quick idea for what may have caused the slow-down? I was thinking about > doing a git bisect, but I figured it is probably way more efficient to > contact the experts! The "experts" here have made lots of changes in the time between 2.33 and 2.37. It's hard to say which one might have caused the extreme slowdown. Bisection is the way to go. I hope it doesn't turn out to be one of the many patches made for fuzzed object files, which may help security a tiny bit but in general don't result in a better binutils. -- Alan Modra Australia Development Lab, IBM