From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id 3DA083857C70 for ; Wed, 16 Feb 2022 11:33:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3DA083857C70 Received: by mail-pl1-x635.google.com with SMTP id u5so1801096ple.3 for ; Wed, 16 Feb 2022 03:33:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition; bh=JtbXs6AXXag3VBjNN23nwWgkxOKrcV3B1n8Zng8m44Y=; b=CYL6wtGarbU/s/oHvir6KJaPaeVlSSCdSCVgZLXsu8PxgPAk8B8bNvUJp8KJ2KGMkF rz6uu0FB8OKka9pgBLDdSqjwCaUS8mm2918TAzv3RQN+c0WXLu4oeRn4M1LQ/dW9O5/I Ka6+y1pb+YWlepK4Mu0aA95cjoDUM99EErwjCKzDGfTDyMatSwZGZAo5dtINyRu5jzQi mdCFLlJ4LlWfaxt6CamxmFv7AikQqENLRu8dsNJ251nEWnYyo1TNowWd459vZJIkez5Q MnSjqsmMnHrH2agLeFOg/p9XV0Wj6Y9ioAew1YYWfjR7RXqeZ6U2IG4eTKD8oVNcNRow gl6g== X-Gm-Message-State: AOAM533GcblJxDQBJpKr4jZ1DHZMUfKNCMyE2jJoOtEjmgZj7247wqHa eeeV/tA10lNM3A5RBzuHEqhkCHTetFY= X-Google-Smtp-Source: ABdhPJwebMmY/l4YMSZJZ67P1wmetjHrkGIZBN4HsngVXsPoFoVqPlZdwV46AfZDGEErhBhWN7mywg== X-Received: by 2002:a17:90a:e7c3:b0:1b9:c189:bc3 with SMTP id kb3-20020a17090ae7c300b001b9c1890bc3mr1197617pjb.202.1645011218067; Wed, 16 Feb 2022 03:33:38 -0800 (PST) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id a29sm5162421pgl.24.2022.02.16.03.33.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Feb 2022 03:33:37 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id D7E2F114145A; Wed, 16 Feb 2022 22:03:34 +1030 (ACDT) Date: Wed, 16 Feb 2022 22:03:34 +1030 From: Alan Modra To: binutils@sourceware.org Subject: pe_ILF_make_a_symbol_reloc segfault Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3037.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Feb 2022 11:33:41 -0000 pei-aarch64-little apparently lacks support for BFD_RELOC_RVA. * peicode.h (pe_ILF_make_a_symbol_reloc): Don't segfault on NULL howto. diff --git a/bfd/peicode.h b/bfd/peicode.h index bbf44813a75..0346bc2174e 100644 --- a/bfd/peicode.h +++ b/bfd/peicode.h @@ -489,7 +489,7 @@ pe_ILF_make_a_symbol_reloc (pe_ILF_vars * vars, internal->r_vaddr = address; internal->r_symndx = sym_index; - internal->r_type = entry->howto->type; + internal->r_type = entry->howto ? entry->howto->type : 0; vars->relcount ++; -- Alan Modra Australia Development Lab, IBM