public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: Fangrui Song <maskray@google.com>
Cc: binutils@sourceware.org, Alan Modra <amodra@gmail.com>,
	Nick Clifton <nickc@redhat.com>, Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH] ld: Support customized output section type
Date: Mon, 21 Feb 2022 14:35:15 -0500	[thread overview]
Message-ID: <YhPpc3Di1KP0Eyf5@vapier> (raw)
In-Reply-To: <20220202071044.1480421-1-maskray@google.com>

[-- Attachment #1: Type: text/plain, Size: 342 bytes --]

On 01 Feb 2022 23:10, Fangrui Song via Binutils wrote:
> --- a/bfd/bfd-in2.h
> +++ b/bfd/bfd-in2.h

it looks like you've edited this file instead of generating.  so when
generating it from its sources, it breaks.  you can verify with:
touch bfd/*.h
make headers

looks like you forgot to update the docs in section.c to include |type|.
-mike

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      parent reply	other threads:[~2022-02-21 19:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-02  7:10 Fangrui Song
2022-02-02 11:36 ` Nick Clifton
2022-02-02 11:46   ` Luca Boccassi
2022-02-02 18:32   ` Fangrui Song
2022-02-03 18:36     ` Luca Boccassi
2022-02-03 19:46       ` Fangrui Song
2022-02-03 20:04         ` Luca Boccassi
2022-02-03 20:48           ` Fangrui Song
2022-02-04 16:05           ` Michael Matz
2022-02-21 19:35 ` Mike Frysinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YhPpc3Di1KP0Eyf5@vapier \
    --to=vapier@gentoo.org \
    --cc=amodra@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=bluca@debian.org \
    --cc=maskray@google.com \
    --cc=nickc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).