From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by sourceware.org (Postfix) with ESMTPS id 1096F385840E for ; Thu, 10 Mar 2022 01:20:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1096F385840E Received: by mail-pg1-x532.google.com with SMTP id q29so2440896pgn.7 for ; Wed, 09 Mar 2022 17:20:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=p4J6CaLPdPMmOWLXFRYXAUHztINffgwxtO/LV6cqQAA=; b=Ug0tsEtRW/Mrgm72fhu8bZLrNisBAmiObm17Q902IjxTlDSH7LDjz6JAWFx07nks7X p0q8qJP6jk0+u98kdEUKYo19+ymMf0JzI/N7Fd3tnRKKdb84IBI0jsJgpwku/9ECRXF6 wxEdtL+YzNUrh5NFdgcPi2ThDqEp9n56CmAUzp8qHYL1cOPKmabF0VtN2sMV14QrMrYu RpZB7Ss4lpaVOwcGZm24rQnCjNz5BnSGTVJCb/RP6sPlZ0s8aCaEISn/snIoYrREiIso c8o9Q4HlCYOGOUsYkZe21+q25tLRbLt5nXXeo9GO9SiGPvKw2nsXWgSCbsOLCblPTNRW PDAw== X-Gm-Message-State: AOAM53273o04RicBLbkKzccnJo5ROtZR9DgDGhjcvNO95L5JXzgNVeKf t0Zefp0eKj4lyKRuV4iv9k36StQJVu0= X-Google-Smtp-Source: ABdhPJyWCT8dNLNhiUXeakRVOUkAhFJZAC7ju0PGVWHdBqUZHVisD1/oGvnGu7XTSxXyFkXLcTHrdg== X-Received: by 2002:a63:500e:0:b0:36c:3697:7aab with SMTP id e14-20020a63500e000000b0036c36977aabmr2055636pgb.98.1646875248286; Wed, 09 Mar 2022 17:20:48 -0800 (PST) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id b13-20020a056a00114d00b004c122b90703sm4399070pfm.27.2022.03.09.17.20.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Mar 2022 17:20:47 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id B49CA1141455; Thu, 10 Mar 2022 11:50:44 +1030 (ACDT) Date: Thu, 10 Mar 2022 11:50:44 +1030 From: Alan Modra To: "H.J. Lu" Cc: binutils@sourceware.org Subject: Re: [PATCH] ld: Add a before_plugin_all_symbols_read hook Message-ID: References: <20220308172230.135655-1-hjl.tools@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220308172230.135655-1-hjl.tools@gmail.com> X-Spam-Status: No, score=-3031.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2022 01:20:50 -0000 On Tue, Mar 08, 2022 at 09:22:30AM -0800, H.J. Lu via Binutils wrote: > Add a before_plugin_all_symbols_read hook to load symbol references from > DT_NEEDED entries, included from --copy-dt-needed-entries, before reading > plugin symbols to properly resolve plugin symbol references. OK, except > * elf-bfd.h (elf_link_hash_table): Add > before_plugin_all_symbols_read. please change the name of this flag to better reflect what it does. "handling_dt_needed" perhaps. You set and clear the flag around the new ldelf_handle_dt_needed function. It isn't set before plugin_call_all_symbols_read and clear afterwards. -- Alan Modra Australia Development Lab, IBM