From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Subject: asan: use of uninitialized value in buffer_and_nest
Date: Thu, 17 Mar 2022 21:30:25 +1030 [thread overview]
Message-ID: <YjMUyWYSJhxGjmrK@squeak.grove.modra.org> (raw)
More occurences of the same as commit d12b8d620c6a.
* macro.c (buffer_and_nest): Sanity check length in buffer
before calling strncasecmp.
diff --git a/gas/macro.c b/gas/macro.c
index cbb9574fd66..2228f5b5404 100644
--- a/gas/macro.c
+++ b/gas/macro.c
@@ -184,9 +184,9 @@ buffer_and_nest (const char *from, const char *to, sb *ptr,
{
if (! flag_m68k_mri && ptr->ptr[i] == '.')
i++;
+ size_t len = ptr->len - i;
if (from == NULL)
{
- size_t len = ptr->len - i;
if (len >= 5 && strncasecmp (ptr->ptr + i, "IREPC", 5) == 0)
from_len = 5;
else if (len >= 4 && strncasecmp (ptr->ptr + i, "IREP", 4) == 0)
@@ -203,15 +203,16 @@ buffer_and_nest (const char *from, const char *to, sb *ptr,
from_len = 0;
}
if ((from != NULL
- ? strncasecmp (ptr->ptr + i, from, from_len) == 0
+ ? (len >= from_len
+ && strncasecmp (ptr->ptr + i, from, from_len) == 0)
: from_len > 0)
- && (ptr->len == (i + from_len)
+ && (len == from_len
|| ! (is_part_of_name (ptr->ptr[i + from_len])
|| is_name_ender (ptr->ptr[i + from_len]))))
depth++;
- if (ptr->len - i >= to_len
+ if (len >= to_len
&& strncasecmp (ptr->ptr + i, to, to_len) == 0
- && (ptr->len == (i + to_len)
+ && (len == to_len
|| ! (is_part_of_name (ptr->ptr[i + to_len])
|| is_name_ender (ptr->ptr[i + to_len]))))
{
@@ -233,7 +234,7 @@ buffer_and_nest (const char *from, const char *to, sb *ptr,
number when expanding the macro), and since for short
macros we clearly prefer reporting the point of expansion
anyway, there's not an obviously better fix here. */
- if (strncasecmp (ptr->ptr + i, "linefile", 8) == 0)
+ if (len >= 8 && strncasecmp (ptr->ptr + i, "linefile", 8) == 0)
{
char saved_eol_char = ptr->ptr[ptr->len];
--
Alan Modra
Australia Development Lab, IBM
next reply other threads:[~2022-03-17 11:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 11:00 Alan Modra [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-02-16 11:31 asan : " Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjMUyWYSJhxGjmrK@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).