From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by sourceware.org (Postfix) with ESMTPS id EDA633888816 for ; Fri, 18 Mar 2022 06:56:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EDA633888816 Received: by mail-pg1-x530.google.com with SMTP id t187so4441217pgb.1 for ; Thu, 17 Mar 2022 23:56:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition; bh=TzYJC8OscymwhSCwODKIYanToasZfL5RpH3w0uDasMk=; b=rHk1+VHpAUwYFjHzac4Mc8B1SWdg9/VYD7mRuMfOSIb3OrSdYLnjG/ic1KhiKiktrY 8jk/lwYYbuiWiydYhqFWTFK4V+zZUGtnX/ClbdNuNIAF7hUIa8B8bTNnYwprIHwHN6ev 4eIQf49ps11B1YMfkjaQt7q6AyRyxH5aq+G1GfPRbk6/RrGmUJNyNM5mQkSruThIc1Ra j90LI0ONQsXDX2W4armx9sG5XaQxKN0o3hC9Rg8bn+kEi0cdVkh0rRLU5neI25pFU5EU SuzTAAkefYnba3LhEOP9RqcqH5qaVuLEiw7288IfuUXugBOPHISm9Wdq0ijeHQnPe1CC KIZw== X-Gm-Message-State: AOAM532WH5rX1tckvhXhjBKjk3/D+Z9wseUxctnegE7WWBAD5DBvQAL2 bIKwNHvHiBI6actpR45870kybfJ18EI= X-Google-Smtp-Source: ABdhPJwX2E3bKtxcGRv3hNMg4IHGG2em8rsPpTmy30/NcCxe/a5EHQGh8Oj4sv2JZ8ZiYVJSAC2+Bg== X-Received: by 2002:a63:5d4d:0:b0:381:c98b:ce72 with SMTP id o13-20020a635d4d000000b00381c98bce72mr6694800pgm.466.1647586609627; Thu, 17 Mar 2022 23:56:49 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:e065:ea48:8006:f85]) by smtp.gmail.com with ESMTPSA id c18-20020a056a000ad200b004cdccd3da08sm9247363pfl.44.2022.03.17.23.56.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Mar 2022 23:56:48 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 4DDCC1140AB2; Fri, 18 Mar 2022 17:26:45 +1030 (ACDT) Date: Fri, 18 Mar 2022 17:26:45 +1030 From: Alan Modra To: binutils@sourceware.org Subject: PR28977 tc-i386.c internal error in parse_register Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3036.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2022 06:56:52 -0000 PR 28977 * config/tc-i386.c (parse_register): Handle X_op not O_register as for a non-reg_section symbol. Simplify array bounds check. diff --git a/gas/config/tc-i386.c b/gas/config/tc-i386.c index 1cc14feeccf..8ef71b62e42 100644 --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -12952,17 +12952,18 @@ parse_register (char *reg_string, char **end_op) { const expressionS *e = symbol_get_value_expression (symbolP); - know (e->X_op == O_register); - know (e->X_add_number >= 0 - && (valueT) e->X_add_number < i386_regtab_size); - r = i386_regtab + e->X_add_number; - if (!check_register (r)) + if (e->X_op == O_register + && (valueT) e->X_add_number < i386_regtab_size) { - as_bad (_("register '%s%s' cannot be used here"), - register_prefix, r->reg_name); - r = &bad_reg; + r = i386_regtab + e->X_add_number; + if (!check_register (r)) + { + as_bad (_("register '%s%s' cannot be used here"), + register_prefix, r->reg_name); + r = &bad_reg; + } + *end_op = input_line_pointer; } - *end_op = input_line_pointer; } *input_line_pointer = c; input_line_pointer = save; -- Alan Modra Australia Development Lab, IBM