From: Alan Modra <amodra@gmail.com>
To: Fangrui Song <i@maskray.me>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] gas: copy st_size only if unset
Date: Sat, 9 Apr 2022 10:13:55 +0930 [thread overview]
Message-ID: <YlDWywmxffa2vfcB@squeak.grove.modra.org> (raw)
In-Reply-To: <20220408212613.inzusw2b2eved25p@gmail.com>
On Fri, Apr 08, 2022 at 02:26:13PM -0700, Fangrui Song wrote:
> On 2022-04-08, Alan Modra wrote:
> > Your patch regressed these tests. Please investigate.
> >
> > aarch64_be-linux-gnu_ilp32 +FAIL: ELF symbol size
> > aarch64-elf +FAIL: ELF symbol size
> > aarch64-linux +FAIL: ELF symbol size
> > alpha-linux +FAIL: ELF symbol size
> > alpha-netbsd +FAIL: ELF symbol size
> > alpha-unknown-freebsd4.7 +FAIL: ELF symbol size
> > hppa64-hp-hpux11.23 +FAIL: ELF symbol size
> > hppa64-linux +XPASS: .reloc against undefined local symbol (PR 27228)
> > hppa-linux +XPASS: .reloc against undefined local symbol (PR 27228)
> > nds32be-elf +FAIL: readelf -wiaoRlL dw5
> > nds32le-linux +FAIL: readelf -wiaoRlL dw5
> > riscv32-elf +FAIL: ELF symbol size
> > riscv64-linux +FAIL: ELF symbol size
> >
> > --
> > Alan Modra
> > Australia Development Lab, IBM
>
> Sorry for the breakage. a3a7f5e1586467b137b8dcdcd2f74f5efa9f3919 should fix aarch64/alpha/hppa/riscv.
Thanks for fixing these.
> I am puzzled by
>
> > nds32be-elf +FAIL: readelf -wiaoRlL dw5
> > nds32le-linux +FAIL: readelf -wiaoRlL dw5
>
> ../../configure CFLAGS='-O0 -g' CXXFLAGS='-O0 -g' --target=nds32be-elf
> make -j 50 all-binutils && make -j 50 check-binutils
> binutils/tmpdir/dw5.o does not change with "gas: copy st_size only if unset"
Hmm, I just did a couple of clean builds and confirmed the fail is
unrelated to your patch. I'll look into why this test was failing for
me.
> > hppa64-linux +XPASS: .reloc against undefined local symbol (PR 27228)
> > hppa-linux +XPASS: .reloc against undefined local symbol (PR 27228)
>
> I am also puzzled by this. I confirm it passes on --target=hppa64-linux
> I'll need to investigate it.
>
>
> PS: is there a shortcut than building all-binutils/all-gas with various
> different --target= (especially these exotic ones like
> alpha/hppa/nds32)?
No, because gas only supports one target, unlike many of the other
binutils that can be configured to support multiple targets.
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2022-04-09 0:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 3:37 Fangrui Song
2022-03-31 6:22 ` Jan Beulich
2022-04-01 1:33 ` Fangrui Song
2022-04-04 11:27 ` Jan Beulich
2022-04-08 7:42 ` Alan Modra
2022-04-08 21:26 ` Fangrui Song
2022-04-08 23:01 ` Fangrui Song
2022-04-08 23:06 ` Fangrui Song
2022-04-09 1:12 ` Alan Modra
2022-04-09 0:43 ` Alan Modra [this message]
2022-04-09 4:29 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlDWywmxffa2vfcB@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=i@maskray.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).