From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id 4126F3858D28 for ; Sat, 9 Apr 2022 01:12:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4126F3858D28 Received: by mail-pl1-x631.google.com with SMTP id be5so3369235plb.13 for ; Fri, 08 Apr 2022 18:12:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=P4rznxmdswXDq+6/V5wNDXFqy5AD/jW0ds2LaEvyd68=; b=UC3M0EcfPhpnvPdlgXjz2dN6oIF4z9Wor/2sEp0FoowYCM0qPP8QOnNjj3t2UJZ4ZI GvON3QoUTx/ViileNN+NehsVRgy23BHHq4xjCEXm2VfQytxYuTuxcDrhrFdw271zHxru 8HkueCRxH3Wn2n+Q4GzoIphAaQmW5m/8ewUjcwHx4fg0VJd7cKM7MEK1i/mwmVQVT+5e ivd6DTC3tXxAr5JIh70RkfVs7XZn1QvCHIY2AGBCyXXZfEXrXQTK00JmLPOTCz8fdwWD CSqxBPJAKdYc63kxlLnmKU/WmNxAdA0hBMtkqA30msBVDgs/WYXT73opvcaytoui5MVg dP5g== X-Gm-Message-State: AOAM533C2PUSX4ZlRVGHHlJfpkYG7T3p2r+Ap+SZq8i9ea7WQQLY+GgN VSZ7+9zcSzINjb3XcUTUXI8b9T8zw/g= X-Google-Smtp-Source: ABdhPJz9pIclo1Z63AgkrFuJJ1epYFJj0ueOxgSZ57jetfjzZ8+TtXmFbELHZl4bmhPVwSW8NoxeSQ== X-Received: by 2002:a17:90b:4c49:b0:1c7:d6c1:bb0f with SMTP id np9-20020a17090b4c4900b001c7d6c1bb0fmr24781978pjb.230.1649466756345; Fri, 08 Apr 2022 18:12:36 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id q6-20020a056a00150600b004fb2d266f97sm28823641pfu.115.2022.04.08.18.12.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Apr 2022 18:12:35 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 2260B1140F9D; Sat, 9 Apr 2022 10:42:32 +0930 (ACST) Date: Sat, 9 Apr 2022 10:42:32 +0930 From: Alan Modra To: Fangrui Song Cc: binutils@sourceware.org Subject: Re: [PATCH] gas: copy st_size only if unset Message-ID: References: <20220331033729.1813121-1-i@maskray.me> <2b2801ff-0bc4-2680-2526-74dd87be3ea0@suse.com> <20220401013343.jeb5ptalaumk7cdq@gmail.com> <20220408212613.inzusw2b2eved25p@gmail.com> <20220408230113.32uq4vep2b3pq5o6@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220408230113.32uq4vep2b3pq5o6@gmail.com> X-Spam-Status: No, score=-3031.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Apr 2022 01:12:39 -0000 On Fri, Apr 08, 2022 at 04:01:13PM -0700, Fangrui Song wrote: > On 2022-04-08, Fangrui Song wrote: > > On 2022-04-08, Alan Modra wrote: > > > Your patch regressed these tests. Please investigate. > > > > > > aarch64_be-linux-gnu_ilp32 +FAIL: ELF symbol size > > > aarch64-elf +FAIL: ELF symbol size > > > aarch64-linux +FAIL: ELF symbol size > > > alpha-linux +FAIL: ELF symbol size > > > alpha-netbsd +FAIL: ELF symbol size > > > alpha-unknown-freebsd4.7 +FAIL: ELF symbol size > > > hppa64-hp-hpux11.23 +FAIL: ELF symbol size > > > hppa64-linux +XPASS: .reloc against undefined local symbol (PR 27228) > > > hppa-linux +XPASS: .reloc against undefined local symbol (PR 27228) > > > nds32be-elf +FAIL: readelf -wiaoRlL dw5 > > > nds32le-linux +FAIL: readelf -wiaoRlL dw5 > > > riscv32-elf +FAIL: ELF symbol size > > > riscv64-linux +FAIL: ELF symbol size > > > > > > -- > > > Alan Modra > > > Australia Development Lab, IBM > > > > Sorry for the breakage. a3a7f5e1586467b137b8dcdcd2f74f5efa9f3919 should fix aarch64/alpha/hppa/riscv. > > I am puzzled by > > > > > nds32be-elf +FAIL: readelf -wiaoRlL dw5 > > > nds32le-linux +FAIL: readelf -wiaoRlL dw5 > > OK, I think this is related to Nick's > 19c26da69d68d5d863f37c06ad73ab6292d02ffa > ("Add code to display the contents of .debug_loclists sections which contain offset entry tables.") > > There is a diagnostic which has moved from somewhere in the middle to > the top: > > readelf: Warning: unable to apply unsupported type 208 to section .debug_loclists > > Adding #... as the first line will fix the test for nds32*, but I am > unsure whether the test should be adjusted to unsupport nds32*. You are exactly correct in your analysis. Or we are both wrong in the same way, because I independently came to the same conclusion. :-) The test shouldn't be adjusted. It's now showing a defect in readelf support for nds32 that was accidentally hidden before Nick's change. -- Alan Modra Australia Development Lab, IBM