From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id 113803857374 for ; Fri, 15 Apr 2022 02:03:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 113803857374 Received: by mail-pl1-x636.google.com with SMTP id n8so6136175plh.1 for ; Thu, 14 Apr 2022 19:03:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AGLpmCEP8wXUan1vNIDzHsvpeivS+zB7LsgDnQBF9Lc=; b=e8tB1zV+LYK7fVhJLQZomo2WAgPPyl/wRsOt/KRd0a4DE8ILYfwF2gdxp6Ll16Io6u 4HTWj3vYJqh8NOQw3lJP1R6LNn08828Hmp+QuqyKB5b5aub/PpcFH2rWFlHIIdESqxl5 4RqZVnAmUqlgLFmZRXGiTIRMOHsFc3/IpbISOaHlH6Owfxqp/9oYLQZhCBN+65aDq2+M 9twnIluJKkWjTCqIkwhlmoW+tLWfkxxLpDFf+Q7TO+D4BwxWYYo/QJCE628HWYg6KuJv 1+v9ojgoe1EOJispSQcN0vWm8VWLP+7FtcFx/7YTqQdjmiiyMjKKZ68gLy8Bf52j+wjm X69w== X-Gm-Message-State: AOAM530M82X9FP+n7QYTqU+OeiuYsBD2x6G6uRC3fVccvlWwJzkmN6Dr 4aonpUFKXbsZUpU4sfcd1pk= X-Google-Smtp-Source: ABdhPJyNtRGwdf55AOaavFPv2ra8gv8pED5pjRvz211OfYRjSgUSLmNq4sVGc4MFXmbmNlGcieoU6g== X-Received: by 2002:a17:903:2045:b0:158:c130:31b7 with SMTP id q5-20020a170903204500b00158c13031b7mr4174994pla.154.1649988216943; Thu, 14 Apr 2022 19:03:36 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id x131-20020a627c89000000b0050977600feasm925827pfc.170.2022.04.14.19.03.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Apr 2022 19:03:36 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 569B41140296; Fri, 15 Apr 2022 11:33:33 +0930 (ACST) Date: Fri, 15 Apr 2022 11:33:33 +0930 From: Alan Modra To: liuzhensong Cc: binutils@sourceware.org Subject: Re: [PATCH] objcopy: Add elf header e_flags option in objcopy. Message-ID: References: <20220414112906.2684102-1-liuzhensong@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220414112906.2684102-1-liuzhensong@loongson.cn> X-Spam-Status: No, score=-3031.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Apr 2022 02:03:40 -0000 On Thu, Apr 14, 2022 at 07:29:06PM +0800, liuzhensong wrote: > @@ -660,6 +666,7 @@ copy_usage (FILE *stream, int exit_status) > --weaken-symbols -W for all symbols listed in \n\ > --add-symbol =[
:][,] Add a symbol\n\ > --alt-machine-code Use the target's 'th alternative machine\n\ > + --alt-elf-eflags= Use the alternative elf header e_flags\n\ Don't use tabs in help messages. > --writable-text Mark the output text as writable\n\ > --readonly-text Make the output text write protected\n\ > --pure Mark the output file as demand paged\n\ > @@ -3496,6 +3503,11 @@ copy_object (bfd *ibfd, bfd *obfd, const bfd_arch_info_type *input_arch) > } > } > > + if (alt_elf_eflags_set) > + { > + elf_elfheader (obfd)->e_flags = alt_elf_eflags; > + } > + Needs a check bfd_get_flavour (obfd) == bfd_target_elf_flavour before writing a field only in ELF bfd, and no need for braces. Also, please update binutils/doc.texi with the new objcopy option. -- Alan Modra Australia Development Lab, IBM