From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by sourceware.org (Postfix) with ESMTPS id 112C53858C2C for ; Sat, 23 Apr 2022 00:15:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 112C53858C2C Received: by mail-pg1-x52a.google.com with SMTP id 15so199565pgf.4 for ; Fri, 22 Apr 2022 17:15:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lOh6YAAiSD3Eu4htVtco4KAxa9hPD/vhfjs+jhCTrBk=; b=3fSbrZwKnG3gtcUPBF4rJJd76TVNgg+T4EtjhLVw87vxz/r6iMqj1jlRxNjflJztYH u9Mtp3Ww8Dj0EOag1tf0JmZLwyxgzwQgYht2vVxoayaLfsSXTZziXXiekPg08NadRQTR 4UQK31sB+xBdkbp1INv0JZqKCKKgQLB6qgApRenj4C2+w+TtFFK8RIxhzUlppz3IxIib thGB26vRGI61XXuYZvrao5hNqCw26wQdSr5XziqMlgcOaVIqdzpCT0B9UGOvAAvN90Pb qiCzZxwR7Yn+kIz5VX9ro6onrXdtwPQ9b0W6WgeQwmPs73ovYZt85nAHdagoJhCVJJI+ LSfg== X-Gm-Message-State: AOAM532XuMajmFlr2tJpK5u54kXtZ5WVfATdGXdmWBWVkHaJFXtsrZoM 4t2zZqUV9jEafIkyElTsEvOyqIhUcpQ= X-Google-Smtp-Source: ABdhPJxblqahfRkL/WnYimrJ/85xmD2EgphxzBX31rPbWYrJfXEsP0VfrbNmaorgRFOwl4NKS4o6ew== X-Received: by 2002:a05:6a00:1411:b0:4fd:e594:fac0 with SMTP id l17-20020a056a00141100b004fde594fac0mr7594075pfu.79.1650672926159; Fri, 22 Apr 2022 17:15:26 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:cc7c:b50c:4a24:c9ca]) by smtp.gmail.com with ESMTPSA id n16-20020a17090a091000b001d2bff34228sm657985pjn.9.2022.04.22.17.15.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 17:15:25 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 30B761140617; Sat, 23 Apr 2022 09:45:22 +0930 (ACST) Date: Sat, 23 Apr 2022 09:45:22 +0930 From: Alan Modra To: Luis Machado Cc: binutils@sourceware.org Subject: Re: [PATCH, v2] [AArch64] Support AArch64 MTE memory tag dumps in core files Message-ID: References: <20220331140457.9237-1-luis.machado@arm.com> <20220421151841.127371-1-luis.machado@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220421151841.127371-1-luis.machado@arm.com> X-Spam-Status: No, score=-3029.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Apr 2022 00:15:29 -0000 On Thu, Apr 21, 2022 at 04:18:41PM +0100, Luis Machado wrote: > v2: > > - Drop arch-specific fields from the generic section data structure. > - Use the rawsize field of the section structure to store the original > memory range of the memory-tagged area. > - Implement the bfd_elf_modify_headers for aarch64, to adjust the values > for the memory tag segment according to the Linux Kernel's format. This looks OK to me, except for defining PT_ARM_MEMTAG_MTE in elf/common.h. That belongs in elf/aarch64.h. BTW, why isn't the header called PT_AARCH64_MEMTAG_MTE? Using PT_ARM_ looks odd, considering that we already have PT_ARM_EXIDX at LOPROC+1. -- Alan Modra Australia Development Lab, IBM