From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by sourceware.org (Postfix) with ESMTPS id DEE0A3857433 for ; Wed, 4 May 2022 09:36:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DEE0A3857433 Received: by mail-pf1-x434.google.com with SMTP id a11so721930pff.1 for ; Wed, 04 May 2022 02:36:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IIjmRAiDxDcTdtondr4goKkEgCtpwDnKpe3Gf91PGY0=; b=ychdK5jXjp+L4cDyOR/Xojc/w6RnfgmnBNdwG+t6InBCNioHpIuyqoIuWZ0Znk3y4c efb0xH8VybCSTxPN+UKbkX1yKKogSGGF6iQ6T0YATbJQiVXs5c0pI1BAmys2ooU2dXQE gpNF5Yji1fKEfqMoXLt3yw2lEX3lC9o47KTtvnh2Jh22ckNoC6/lJsxpHzPGEzPiXCfF WIgqJ78GRwPeZmGKbmUq2aDdAUVrNItZThbypgutyxE2d+wAR+YNn1sa6+t6RNHXtq9q EnjIPysY1eC6JI88BC3goFE0hvu6xPSFQ6JDCc1Qv709eYjednjcAqWhcpAfaUCl1ZZy pJFw== X-Gm-Message-State: AOAM533O5sHUVd2SZ8S+d8ryVT9K2dYCvX6XiVp/hLjQNCUQxW5av5eq 8uWJSyHR8U8AeDVDiQU66/j+P4bJfZw= X-Google-Smtp-Source: ABdhPJz1wQkiqYfFvsPTuvYatgoUFTuf28pAOEd0a4mo6oJ6/9HfXADqHRaE+y18CCIzQNf3LEnnUw== X-Received: by 2002:a63:120a:0:b0:3c4:a040:9cb2 with SMTP id h10-20020a63120a000000b003c4a0409cb2mr3250812pgl.200.1651657006661; Wed, 04 May 2022 02:36:46 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id d16-20020aa78690000000b0050dc7628148sm7762644pfo.34.2022.05.04.02.36.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 May 2022 02:36:45 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 2C2FB1140F08; Wed, 4 May 2022 19:06:43 +0930 (ACST) Date: Wed, 4 May 2022 19:06:43 +0930 From: Alan Modra To: Jan Beulich Cc: Binutils Subject: Re: gas: set_symtab()'s setting of BSF_KEEP Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-3031.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2022 09:36:49 -0000 On Wed, May 04, 2022 at 10:54:25AM +0200, Jan Beulich wrote: > Alan, > > while looking into how to address an Arm64 regression I ended up > coming across this code, originating from commit 76d129399558. The > first thing that puzzled me was the != for checking BSF_SECTION_SYM. The test is to prevent any attempt to change the const global_syms[]. That's why flags != BSF_SECTION_SYM is quite OK. It would be cleaner to write a bfd_is_const_symbol similar to bfd_is_const_section. -- Alan Modra Australia Development Lab, IBM