From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id 1F0973857401; Thu, 12 May 2022 00:13:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1F0973857401 Received: by mail-pl1-x629.google.com with SMTP id d22so3359727plr.9; Wed, 11 May 2022 17:13:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mww8lOulNngszslCTDBCNB6tcEgXQVKGQGtdAwiPA7M=; b=qeCIXYOYdEtyM1pfHrtES27Tvp+7BoGC2KIDyKJTLoHx8vK2MFCxcmCvTlhBXwTieZ yysYwHzu4i0WGYRAiUUerLsYO9qUwY3rMZYNisTs3XEGzu0zj1+v6MBKmRrqJpQM8r1H CSTaCBvioU40nBI5da8kF6OAx4nYdgpYBxghjnEf4XSsiD35DZ+5U7IXfVCUVwRkR+at l8NIKEJSYoBO600FqKLAbQ+LVZo0o4frp6jLM+kTF9qvckNQWu4MAKFOjXKJa5fA7PS4 dMyun0NeCXFh/5nGrCqL8Zl4h5bvSmr92VK0RssH6CgD0hUzo2KMFd6zkYesq8OOLQFU yyag== X-Gm-Message-State: AOAM533rytcwql6MZ1cl/IY10y19Vav2kYT7Bk5KfOd+nfp+23zAABrV HpJH1mjSFH+L7jpyOWFeQGA= X-Google-Smtp-Source: ABdhPJy+yUj/uZd7U5C/isr2NmPPCnuccWUE1TY7l2rRTN3+RDaaHo2omgMJGoaJamqt2IYT52EVsg== X-Received: by 2002:a17:90b:3508:b0:1dc:c275:3e18 with SMTP id ls8-20020a17090b350800b001dcc2753e18mr8018401pjb.245.1652314438202; Wed, 11 May 2022 17:13:58 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id gw19-20020a17090b0a5300b001cd4989ff60sm505845pjb.39.2022.05.11.17.13.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 May 2022 17:13:57 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id B02F9114215A; Thu, 12 May 2022 09:43:54 +0930 (ACST) Date: Thu, 12 May 2022 09:43:54 +0930 From: Alan Modra To: Dmitry Selyutin Cc: binutils@sourceware.org, gdb-patches@sourceware.org, Luke Kenneth Casson Leighton Subject: Re: [PATCH 1/2] ppc: extend opindex to 16 bits Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-3031.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 May 2022 00:14:01 -0000 On Wed, May 11, 2022 at 08:59:19PM +0300, Dmitry Selyutin wrote: > + Also, this field is signed due to historical reasons. */ Huh? What makes you say that? Also, your patch misses changing the following. The existing 0xff mask was from a time when fx_pcrel_adjust was a signed char. int opindex = fixP->fx_pcrel_adjust & 0xff; This could be any of int opindex = fixP->fx_pcrel_adjust & 0xffff; int opindex = (uint16_t) fixP->fx_pcrel_adjust; uint16_t opindex = fixP->fx_pcrel_adjust; Which you choose is a matter of style. -- Alan Modra Australia Development Lab, IBM