From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by sourceware.org (Postfix) with ESMTPS id 42F57385740F for ; Thu, 12 May 2022 03:55:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 42F57385740F Received: by mail-pj1-x102f.google.com with SMTP id gj17-20020a17090b109100b001d8b390f77bso6690268pjb.1 for ; Wed, 11 May 2022 20:55:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition; bh=18e5tw9dSEGd5E9HhMhA8apZrm+Nw4cGV3OlfTcIA0A=; b=nByaLaygHvtShpWvrED04Ty6+g9CkbeT0/XB+CB7Aj8pVqzV1nlcDhbis73jv04lnH 9anHA07Znovsg5FHvC+a4frmgk4au08xp58hKWFvawHSIgKPd2ZT/ppW9RSTjidWW01Z yfOOZKbkzG6jPGjpv63Sl2/FaTtWXMDJ7f/JH8kLm+cSXKlFRPg6Y9MKEq+N9/gYiJmP c8pCB+FTwJ+mlamuNqj719Lr66GWz7tuEV/E7UHCVsvTuCSGOyGxDMPpPqZuxtj/UUBm zNRJpRo7s/dF3PyL2lDCg+X0WXMf99SGHGNT1rXVS7RzKtsbwegqV18z76jcQrge/hd+ lvqg== X-Gm-Message-State: AOAM531FC7mgbnfXWtF0A0OigBHQiqGjbDjI+YB7osCFlIUL6tZW2suF 6AwGC/TjcJZzjcXa4jUSO8eiGL94xb8= X-Google-Smtp-Source: ABdhPJz4VCIbZIOuNnLgPgiLtyWKVZ8OLBV6f/O28uIpdl8um2pa7+5yXO8me1U/L5YPuWWBAkAjNA== X-Received: by 2002:a17:90b:1c8e:b0:1bf:364c:dd7a with SMTP id oo14-20020a17090b1c8e00b001bf364cdd7amr8595932pjb.103.1652327738023; Wed, 11 May 2022 20:55:38 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id l10-20020a17090a850a00b001da160621d1sm676427pjn.45.2022.05.11.20.55.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 May 2022 20:55:37 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 205A31143468; Thu, 12 May 2022 13:25:35 +0930 (ACST) Date: Thu, 12 May 2022 13:25:35 +0930 From: Alan Modra To: binutils@sourceware.org Subject: cgen: increase buffer for hash_insn_list Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3037.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 May 2022 03:55:40 -0000 As was done for hash_insn_array in commit d3d1cc7b13b4. * cgen-dis.c (hash_insn_list): Increase size of buf. Assert size is large enough. diff --git a/opcodes/cgen-dis.c b/opcodes/cgen-dis.c index 4137e39bd38..993deeb26b4 100644 --- a/opcodes/cgen-dis.c +++ b/opcodes/cgen-dis.c @@ -153,8 +153,9 @@ hash_insn_list (CGEN_CPU_DESC cd, for (ilist = insns; ilist != NULL; ilist = ilist->next, ++ hentbuf) { unsigned int hash; - char buf[4]; + char buf[8]; unsigned long value; + size_t size; if (! (* cd->dis_hash_p) (ilist->insn)) continue; @@ -163,10 +164,9 @@ hash_insn_list (CGEN_CPU_DESC cd, to hash on, so set both up. */ value = CGEN_INSN_BASE_VALUE (ilist->insn); - bfd_put_bits((bfd_vma) value, - buf, - CGEN_INSN_MASK_BITSIZE (ilist->insn), - big_p); + size = CGEN_INSN_MASK_BITSIZE (ilist->insn); + OPCODES_ASSERT (size <= sizeof (buf) * 8); + bfd_put_bits ((bfd_vma) value, buf, size, big_p); hash = (* cd->dis_hash) (buf, value); add_insn_to_hash_chain (hentbuf, ilist->insn, htable, hash); } -- Alan Modra Australia Development Lab, IBM