From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by sourceware.org (Postfix) with ESMTPS id E293A38560A0 for ; Wed, 25 May 2022 02:50:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E293A38560A0 Received: by mail-pf1-x42d.google.com with SMTP id x143so18034180pfc.11 for ; Tue, 24 May 2022 19:50:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:resent-from:resent-date:resent-message-id :resent-to:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6WH6F/3aMb/IO9f6bC+C8zgrl/WYHddeHOp0Oftri8c=; b=CNVUCPl+XSNyat5+GqvAvpF+6r5i64dldK7BrqJquMKHi71iY17BnSrg5emFiZSlxt UuX3wwlUXq4habeJyVUYmDeIUZANWPc+6NFKbo/d29nK+e34g6w5K0Y+l4nquoCWNFoU gqM/j/nzmakYn4394bzAw3yV9RJN3R6n1K47EmwtklLF/D3PrIFL04y0/QoCIg5s7yk/ fuaYTdoTZN+eaMz92cFEja62Flnury7fwV25I/k6+2qhKTfe3vWMMUcNQZy00nm1kwrP d+Uv/Sv0G//E1o/i0KBsvBRg+4d5iygTGXa3V7H4LBitSk5NbogV6dtChe2md91RDN25 SolA== X-Gm-Message-State: AOAM532hkaO7EbMFYYizuOuRJrp9wJYLgr2Yqnt8MR1t1nfvTKfsjAz9 eLKT9S+1ujis7mfjq1wlYvP2s1JsVus= X-Google-Smtp-Source: ABdhPJxoNGNpZH3FkqWG8S6aRwFzFPwGivPIh2pwX4SD70Iksj61UoulLh+43eCvljGEAGS3kM7pdw== X-Received: by 2002:a63:6cc7:0:b0:3f6:ba59:1bcc with SMTP id h190-20020a636cc7000000b003f6ba591bccmr21060407pgc.188.1653447043089; Tue, 24 May 2022 19:50:43 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id l1-20020a170902f68100b0015e8da1fb07sm8168969plg.127.2022.05.24.19.50.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 May 2022 19:50:42 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 2041B1140193; Wed, 25 May 2022 12:20:40 +0930 (ACST) Resent-From: Alan Modra Resent-Date: Wed, 25 May 2022 12:20:40 +0930 Resent-Message-ID: Resent-To: Dmitry Selyutin , binutils@sourceware.org, lkcl@lkcl.net Date: Wed, 25 May 2022 12:11:11 +0930 From: Alan Modra To: Dmitry Selyutin Cc: binutils@sourceware.orglukekennethcasson, Leighton Subject: Re: [PATCH 0/2] extend opindex and fx_pcrel_adjust to 16 bits Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-3031.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2022 02:50:45 -0000 On Wed, May 25, 2022 at 12:09:15AM +0300, Dmitry Selyutin wrote: > Hello all, just in case the previous message was missed, I'd like to ping > about the patches again. Sorry, I haven't been very active over the last few weeks. I'm about to apply the ppc_opindex_t patches, squashed into one, and your isel patch. I've made some comment changes, plus gone back to masking fx_pcrel_adjust, the reason being that if someone needed to reduce fx_pcrel_adjust to, say, 12 bits to accomodate some new struct fix field, they could do so with only a change to PPC_OPINDEX_MAX in the ppc target code. A cast to ppc_opindex_t wouldn't work in that situation I believe, you'd get the 12-bit signed value being extended to an int, then masked to 16 bits by the cast. -- Alan Modra Australia Development Lab, IBM