From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by sourceware.org (Postfix) with ESMTPS id 970B93856086 for ; Wed, 25 May 2022 04:30:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 970B93856086 Received: by mail-pg1-x534.google.com with SMTP id c22so17970977pgu.2 for ; Tue, 24 May 2022 21:30:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=M8CtbaqnVilVZ/kiCuC5FoT0P5cRppMEmr7kGalDakg=; b=v5DK+/023q057+OGj9yxVSb18pzVBgEex4T8jxHzoNishTr7NCB8Ncb57ow5niU/jC jsXYOff7+DRSzHkAShOf8fCrp9FgLiMRR/tTxZ+jEk53ywwjBEgNw6HXqpX7rOonif3g mdVJufL+ErGba5rZFmwgeLDa4VFGpnZCFaoCS+B6HXFTmdZ6B0PQ40t9RXajhJVhzlV1 QWte3O75KnOwLDqQcTgV6UuOuWUOgAlbWuoXIiK+UIdNxGffE9/VK/M6mh4hTfh+AJeQ 6BV8SMmYLeSX1ULiullw0hMC+MHGfJWa/Guq5k7UKA7MS+mAgx662RpWBIKReqrlV+59 hHLQ== X-Gm-Message-State: AOAM531z5MFGVTzFTJKI84fGcCr6UxLk+pNuMV09Dci27veLTtg5Bmr4 GEn2lEtzGW+ZTPNshQuK8Sc= X-Google-Smtp-Source: ABdhPJw6Er/13/a7OwP7bXs4G+Jncl64JQLUGXmgLk+2jXstckBFNZIspxBHsLs26bIi5YjFEKwkHg== X-Received: by 2002:a05:6a00:2a03:b0:518:2d8d:8c46 with SMTP id ce3-20020a056a002a0300b005182d8d8c46mr31590083pfb.15.1653453011646; Tue, 24 May 2022 21:30:11 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id bg10-20020a1709028e8a00b0015e8d4eb21dsm8079811plb.103.2022.05.24.21.30.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 May 2022 21:30:10 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 2BB941140434; Wed, 25 May 2022 14:00:08 +0930 (ACST) Date: Wed, 25 May 2022 14:00:08 +0930 From: Alan Modra To: luca.boccassi@gmail.com Cc: binutils@sourceware.org Subject: Re: [PATCH v2] ld: add --package-metadata Message-ID: References: <20220515191846.114257-1-luca.boccassi@gmail.com> <20220524211507.177629-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220524211507.177629-1-luca.boccassi@gmail.com> X-Spam-Status: No, score=-3031.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2022 04:30:16 -0000 On Tue, May 24, 2022 at 10:15:07PM +0100, luca.boccassi--- via Binutils wrote: > v2: fix style issues > fix ASAN issue: note storage is rounded up, but that size > was used to read the json input, which is fixed > add entry to NEWS > add note about json validation to docs Looks OK to me > + if (json_length > SIZE_MAX) > + { > + einfo (_("%P: warning: --package-metadata is too long, ignoring\n")); > + return false; > + } except for the above dead code. OK with that removed. -- Alan Modra Australia Development Lab, IBM