From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by sourceware.org (Postfix) with ESMTPS id 123C63856091 for ; Wed, 25 May 2022 06:02:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 123C63856091 Received: by mail-pj1-x1032.google.com with SMTP id q92-20020a17090a17e500b001e0817e77f6so763542pja.5 for ; Tue, 24 May 2022 23:02:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3kDTrGdpsxnVJrFTcowU7njGxlxasKwyor1FxKM4yj0=; b=UJQOCAT6UoWv1sSQsIYpgEy+KU9Cm+Yu43NIagMDxdZgisZlBSSDx4YHxEcUULsUlA du+cteEa5biDumq8iS92k+O2eDd/f8e4vqRlVn1avTVMvlkFjOtBkB7tDG9aELp9+jbW KcTMEG72p9dmg6I7SVtJo9DtiOleEX3QeCfjFIYl0heNj7JdSzqVao3NurFomH/pKcN6 PTbPuzBq2gQAL+KXPtyjO/7QYbIoOVLpbnfnJm7mWqBrouOM9tlcDdu+ee6r8wKqTe3d lfdgPIXLxxA2yqQZnu8B4zItyGbHHbOKo6RYOCqw3VLABAksMo9KvJmg3MzgUmBSezB8 thLw== X-Gm-Message-State: AOAM531SMs23z4c41J0WM2vW5FbPuf/2nXsISKaxzU33JVc9P55ztyRA qeyOaseeUIGrpDxLuNt2oJg= X-Google-Smtp-Source: ABdhPJy7ShWFeWdtgXfske2gGtKc9Yx9PtH1L46IGJJoFwrzKfsLnKfgsIDRl0/538y0Z1wFGyHPxg== X-Received: by 2002:a17:90b:3142:b0:1df:77f2:e169 with SMTP id ip2-20020a17090b314200b001df77f2e169mr8404196pjb.245.1653458563168; Tue, 24 May 2022 23:02:43 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id bd30-20020a056a00279e00b0051868418b06sm10360579pfb.35.2022.05.24.23.02.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 May 2022 23:02:42 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 83D061140124; Wed, 25 May 2022 15:32:39 +0930 (ACST) Date: Wed, 25 May 2022 15:32:39 +0930 From: Alan Modra To: luca.boccassi@gmail.com Cc: binutils@sourceware.org Subject: Re: [PATCH v2] ld: add --package-metadata Message-ID: References: <20220515191846.114257-1-luca.boccassi@gmail.com> <20220524211507.177629-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-3031.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2022 06:02:47 -0000 On Wed, May 25, 2022 at 02:00:08PM +0930, Alan Modra wrote: > On Tue, May 24, 2022 at 10:15:07PM +0100, luca.boccassi--- via Binutils wrote: > > v2: fix style issues > > fix ASAN issue: note storage is rounded up, but that size > > was used to read the json input, which is fixed > > add entry to NEWS > > add note about json validation to docs > > Looks OK to me > > > + if (json_length > SIZE_MAX) > > + { > > + einfo (_("%P: warning: --package-metadata is too long, ignoring\n")); > > + return false; > > + } > > except for the above dead code. OK with that removed. And how having applied your patch locally and tested, please do look into fixing FAIL: bootstrap FAIL: bootstrap with strip FAIL: bootstrap with -Wl,--traditional-format FAIL: bootstrap with -Wl,--no-keep-memory FAIL: bootstrap with -Wl,--relax FAIL: bootstrap with -Wl,--max-cache-size=-1 seen with #define HAVE_JANSSON 1 The errors are of course all due to undefined references to libjansson symbols. -- Alan Modra Australia Development Lab, IBM