From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by sourceware.org (Postfix) with ESMTPS id 19A2D3857B90 for ; Wed, 25 May 2022 07:23:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 19A2D3857B90 Received: by mail-pg1-x531.google.com with SMTP id x12so18207875pgj.7 for ; Wed, 25 May 2022 00:23:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Txc0/uuNTNi5TeS40sDO7IrGGA+bCUvzB/EBt/FNFJE=; b=r6IbGgONkk4RLhqH87Js8N2h8A/leejH6Lr7FwkDaPUGoU7Hht+1RN+pj/IIsgqLAL kkRLrtyKu/eqM0JRNa+EZ5raghfAYFpI0qrlvY9oOwLrN7OYJ5/DS/nuwBsbTnPIAwMO H7Ed9F2tv63z3Cc7M/Ka2RlMUz2ig1oBd1HAva1XHTKes/XsqJ910Z1HEwK1mTdntI4n 1IIUux/wKnBpICDhWao3CE+16U/s0tENCJhQ/9POXnKf4TP3qGdheapjZf9IOFG3i7cm VBClLArMQPOxCve4MAf8ifZzGnC8+DcBbAwvh7TYfEuVww4AASzORt+lFMjPfx1RL2H6 tVRA== X-Gm-Message-State: AOAM531QdWvBJjgXWqMxjULkf83XLW6+cdCZeXyqPvhxgVMet4BkWcGG 2judWkDBKoT5+iKI99wFlkpfrY7O+zE= X-Google-Smtp-Source: ABdhPJwe0NO48bRzNQ+NuSCfxVHTyA3KX95yI1nZHMNa6yS2r2Zutj3MRiTzHUDf3zxqhlC12bxbLw== X-Received: by 2002:aa7:92d2:0:b0:518:4929:e4cc with SMTP id k18-20020aa792d2000000b005184929e4ccmr29079231pfa.37.1653463433173; Wed, 25 May 2022 00:23:53 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:b98d:4636:5904:9e80]) by smtp.gmail.com with ESMTPSA id l1-20020a170902f68100b0015e8da1fb07sm8740884plg.127.2022.05.25.00.23.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 May 2022 00:23:52 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id C1BBC114015B; Wed, 25 May 2022 16:53:49 +0930 (ACST) Date: Wed, 25 May 2022 16:53:49 +0930 From: Alan Modra To: Tatsuyuki Ishi Cc: binutils@sourceware.org Subject: Re: [PATCH 2/4] gas: Add support for LLVM addrsig and addrsig_sym directives on ELF. Message-ID: References: <20220525064252.58603-1-ishitatsuyuki@gmail.com> <20220525064252.58603-3-ishitatsuyuki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220525064252.58603-3-ishitatsuyuki@gmail.com> X-Spam-Status: No, score=-3029.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2022 07:23:55 -0000 On Wed, May 25, 2022 at 03:42:50PM +0900, Tatsuyuki Ishi via Binutils wrote: > + for (symtab_index = 0, symp = symbol_rootP; symp; symp = symbol_next (symp)) > + { > + if (S_GET_ADDRSIG (symp)) > + len += out_uleb128 (symtab_index); > + if (symbol_written_p (symp)) > + symtab_index++; > + } This looks odd, seemingly allowing multiple uleb output for the same index. Wouldn't the following be better? if (symbol_written_p (symp)) { if (S_GET_ADDRSIG (symp)) len += out_uleb128 (symtab_index); symtab_index++; } > +bool > +S_GET_ADDRSIG (symbolS *s) > +{ > + if (s->flags.local_symbol) > + abort(); "return false" rather than "abort()" please. > + return s->flags.addr_sig; > +} -- Alan Modra Australia Development Lab, IBM