From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by sourceware.org (Postfix) with ESMTPS id 658AD38425B4 for ; Wed, 25 May 2022 07:30:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 658AD38425B4 Received: by mail-pl1-x630.google.com with SMTP id q18so17858505pln.12 for ; Wed, 25 May 2022 00:30:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cMXXXMzmsJGyEiWhDt8DeaAXDGpeREKrHbltw+V77Qo=; b=f+X7SoH+6OoP/W1V3SkizZk/V6KkQcc7w4XSTK/PuVNog7ZvHweAtJwq1rt1wrEq8W abD9jBKAd9qqhuHJ2bmuRu0Fg6xkQ5b8mTfgWPCK8Xy8A/m9dj3MOpR3WC0B3pGeBpfF Id0PnzsjzjGrjMj+DqFlxLVhg7zST7HLzMxTNkvw8AtX7szvQCNI8Anb1ijBC+6JHoE4 BtEqttsx8WcJ8unJsLYtauHrUuQ2bZjIBpBjXWEqfLKA55RTsVUPjWnQShz7Mk4nXDGN +D1e+nhsJ+YiyE5ahuF2DOgVhvq3uSRx/psS1pUNNfkYkBgVxusnYjUQvVZIODSA3DAO OxVw== X-Gm-Message-State: AOAM533XPlv2rWK7SI4BZyLhLDxStXOuH0Yj5I1suwQBg1xioOcUxonz 2DSU6HOZTkAGilbEfFaJwxc= X-Google-Smtp-Source: ABdhPJydKDS4vEjeiReyJ5HvOJPJaXauU3XsmFnkW/T06z1mjkQABN3FnwQKUC7VHQOb7C3UjBtCmQ== X-Received: by 2002:a17:902:f688:b0:162:28c7:73cb with SMTP id l8-20020a170902f68800b0016228c773cbmr12886766plg.63.1653463840338; Wed, 25 May 2022 00:30:40 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:b98d:4636:5904:9e80]) by smtp.gmail.com with ESMTPSA id c10-20020aa7952a000000b0051841e6630esm10573736pfp.199.2022.05.25.00.30.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 May 2022 00:30:39 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id ED203114015B; Wed, 25 May 2022 17:00:36 +0930 (ACST) Date: Wed, 25 May 2022 17:00:36 +0930 From: Alan Modra To: Tatsuyuki Ishi Cc: binutils@sourceware.org Subject: Re: [PATCH 4/4] gas: Add basic test for addrsig. Message-ID: References: <20220525064252.58603-1-ishitatsuyuki@gmail.com> <20220525064252.58603-5-ishitatsuyuki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220525064252.58603-5-ishitatsuyuki@gmail.com> X-Spam-Status: No, score=-3029.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2022 07:30:42 -0000 On Wed, May 25, 2022 at 03:42:52PM +0900, Tatsuyuki Ishi via Binutils wrote: > These are very basic tests to ensure that the addrsig directives are > correctly parsed and something is emitted. New tests should be checked on multiple targets. > +tmpdir/addrsig.o: file format elf64-x86-64 This will obviously fail on anything other than x86. > +++ b/gas/testsuite/gas/elf/addrsig.s > @@ -0,0 +1,10 @@ > +.addrsig > +.addrsig_sym g1 > +.globl g2 > +.addrsig_sym g3 > +.addrsig_sym local > +.addrsig_sym .Llocal > + > +local: > +.Llocal: > +.Llocal_hidden: Please indent directives with a space or tab. Some targets assume that text starting in the first column is a label. -- Alan Modra Australia Development Lab, IBM