From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by sourceware.org (Postfix) with ESMTPS id DEF293834E4A for ; Thu, 26 May 2022 07:02:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DEF293834E4A Received: by mail-pl1-x630.google.com with SMTP id b5so717996plx.10 for ; Thu, 26 May 2022 00:02:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=SXYO5QDH1Mqu3G/62OUppoDp6vU7G5ve86OAFzr+ujM=; b=QZor8EWBz4XVPqGTqwORPz9wJuvyjdofwlz/btDYXi4ECCrJGcRW0v1693Rz80+R/T dbeTFsEGOaYs/t7w2Qh22/1Ykk/6HFLqHawagLFr19N0FU12Dcgw9KeRCeoxZAtHyUNi u4SsJFVYu1Q1iOLEwn8hx0Z78XgLgG8EKLb6le5g/Imwx5+GaflI1c5zD3dSkYsC11Tn Z4bRrSgrmDqHFHeA54uWMxfKO0bH7g/Us98Qr491IlmknMOhFeVbgsS38Aj0wPlfUEAY +jAF128MzIeuG5w4ZxqiJD3BpTNo06J44sHemAFa5HuvhN/7KI4zGzn6pAvjGEovkO1T 78Nw== X-Gm-Message-State: AOAM533VjOdhqka+HEx9YpqNOIqlp02J0xZ025Swc07kJtVtkfvNL90c f7lIpx3Bjj1eSuqnRuH0qY8= X-Google-Smtp-Source: ABdhPJzN/MhtS6hGk3McUqtoL+YKG2w9ucw2t9mLeM/kwB6OYOjMrtiAsOpWV7erGAtfrEgTfbr+iQ== X-Received: by 2002:a17:902:ea57:b0:15a:6173:87dd with SMTP id r23-20020a170902ea5700b0015a617387ddmr37145066plg.147.1653548545953; Thu, 26 May 2022 00:02:25 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:1284:35a7:4b08:d932]) by smtp.gmail.com with ESMTPSA id u4-20020a17090341c400b0015e8d4eb292sm689087ple.220.2022.05.26.00.02.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 May 2022 00:02:24 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id E5BBB114015B; Thu, 26 May 2022 16:32:21 +0930 (ACST) Date: Thu, 26 May 2022 16:32:21 +0930 From: Alan Modra To: "Potharla, Rupesh" Cc: "binutils@sourceware.org" , Jan Beulich , "George, Jini Susan" , "Parasuraman, Hariharan" , "Natarajan, Kavitha" Subject: Re: [PATCH V2] bfd: Add Support for DW_FORM_strx* and DW_FORM_addrx*. Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-3029.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 May 2022 07:02:32 -0000 Thanks for the patch. I'm going to commit it with some formatting fixes, and a few improvements. - reread_attribute no longer copies its attr arg. - str_addrp is alloc'd in chunks, not on each addition. - error paths out of parse_comp_unit free str_addrp. - variables used as offset into arrays are now size_t. -- Alan Modra Australia Development Lab, IBM