From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by sourceware.org (Postfix) with ESMTPS id 8135338344E0 for ; Thu, 26 May 2022 11:07:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8135338344E0 Received: by mail-pj1-x1030.google.com with SMTP id qe5-20020a17090b4f8500b001e26126abccso273937pjb.0 for ; Thu, 26 May 2022 04:07:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=oGNUxzI+GziFhWJJhrkUC25I4AID1bxYQhQPBY/xh6I=; b=fbBB9oqTHmoz8uBIKQQq1ZESoPOgAhSpWdcCPXAAls+sOyA8z7j4xpGva0w8L1otMz MZ7bYcC5n0MdQjC4Ycxjm61nzlkSFfmlU4muR85oG7gShD+IjWCgQ4Q6dIbWtMG4v9/6 x2OV48GDrZxK+LnTFVo4iqDmWfRsBJaiu6d9hvpg+ovC9UNkv6QlmjYH8hbM11WYdxAR eSAOZTaCsFIDRkIySEK3/MoDjNM8ARH+Nwi9xRO5GH6hlW9co/RlLKSqxLzS+AHIzzSy lCWbusDVGejSePqLvRXkTExIhIHqksPFgthbBy1WKI+1lDsfPbmY+BCU3Fr4Bn/SfGD5 xgQg== X-Gm-Message-State: AOAM531vZ4n2dW6ChkcwJjeOygdNiUw0NSDE2SJBU4j6QpSzoHv8Q7Fq zovyzUUdDgAMG3szyb+cZforz5cPAvw= X-Google-Smtp-Source: ABdhPJxtlOf8p3QylYX9FtmaAzCqfZ8mwrf84V+zLDILy6UXCap6eStCNKSad18HQ7Q4pmtBz770JA== X-Received: by 2002:a17:90a:5d03:b0:1e0:90f5:3799 with SMTP id s3-20020a17090a5d0300b001e090f53799mr2020703pji.227.1653563219417; Thu, 26 May 2022 04:06:59 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id e25-20020aa78c59000000b005182d0a3d5csm1207943pfd.7.2022.05.26.04.06.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 May 2022 04:06:58 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 2889D1140248; Thu, 26 May 2022 20:36:56 +0930 (ACST) Date: Thu, 26 May 2022 20:36:56 +0930 From: Alan Modra To: binutils@sourceware.org Subject: bit-rot in target before_parse function option Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-3037.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 May 2022 11:07:02 -0000 On Fri, May 20, 2022 at 07:46:10PM +0930, Alan Modra wrote: > On Fri, May 20, 2022 at 09:07:06AM +0200, Clément Chigot wrote: > > However, the testsuite changes look mandatory to me. > > As of now, the results are different dependending on the > > configure options being passed. > > Yes, you may well be correct. I'm going to leave this to Nick. > Incidentally, the reason why I didn't fix the arm/aarch64 regressions > is that if > > link_info.separate_code = DEFAULT_LD_Z_SEPARATE_CODE; > link_info.warn_execstack = DEFAULT_LD_WARN_EXECSTACK; > link_info.no_warn_rwx_segments = ! DEFAULT_LD_WARN_RWX_SEGMENTS; > link_info.default_execstack = DEFAULT_LD_EXECSTACK; > > is added to armelf.em:before_parse then we get > > FAIL: PR ld/29072 (ignore absent .note.GNU-stack) > > The reason being that arm is listed in ld/testsuite/ld-elf/elf.exp > target_defaults_to_execstack but doesn't have > elf_backend_default_execstack set. I guess I really shouldn't just palm this off to Nick, leaving testsuite regressions. Copy initialisation over from the elf.em before_parse. Commit ba951afb999 2022-05-03 changed behaviour on arm and score regarding exec stack. This patch restores the previous behaviour. * emultempl/aarch64elf.em (before_parse): Init separate_code, warn_execstack, no_warn_rwx_segments and default_execstack. * emultempl/armelf.em (before_parse): Likewise. * emultempl/scoreelf.em (before_parse): Likewise. * testsuite/ld-elf/elf.exp (target_defaults_to_execstack): Return true for arm and nacl. diff --git a/ld/emultempl/aarch64elf.em b/ld/emultempl/aarch64elf.em index 26e3dd243fc..1968f12cf29 100644 --- a/ld/emultempl/aarch64elf.em +++ b/ld/emultempl/aarch64elf.em @@ -54,6 +54,10 @@ fragment <