From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by sourceware.org (Postfix) with ESMTPS id 92B723856249 for ; Fri, 20 May 2022 10:16:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 92B723856249 Received: by mail-pl1-x633.google.com with SMTP id i1so6984893plg.7 for ; Fri, 20 May 2022 03:16:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=+b7zRWHshnxAYFO+C95+W6ELIziPdrh0Wm+N8wdRFW8=; b=deoQtg7N8m18hehbZSQ594R8UQA9hRVUbVM8w9uwiGgMVqu/OymSduGoH4wfGB+dQJ 3+ingd2krKU9U+FAfGwv0Azk4Fa6wZbdXIAlfeAhzLbkDE0DGX7ZxwaJs6K6mEn4yErV Y7ktl3wr1EDVGXdzT7NHKVCFQniMZp/eVnowBIWIhBNU/SWUJpxc5eW/n9EF3TW7431n e+k6V1xr992LeLS30Jn9fPFhzO22k+ZscsoZV6DE2bc4RcbyU45/HBnn1bm4IB8EbSyR QnM03n5DsWj/IETCY3QdQ7GdxMkvuRwNgUK0A5GIPURzvxhE2zwKLkLEAQytLPGmZMFO VZdA== X-Gm-Message-State: AOAM5325pi7XEgXN201dVa/WClL5GS+H9s3tTkSfvlJ4xQ69ny+9d2j3 k/XpVSGj6zVjUi0xFAaKf2d73I/QA+k= X-Google-Smtp-Source: ABdhPJxsuz9CbDKm0wGRosbUZVfmCXZkxSVIOTeW6DLlpdI5764DKIN6FT1ytgxZAJKhSnt4HOtr4A== X-Received: by 2002:a17:903:1211:b0:15e:8208:8cc0 with SMTP id l17-20020a170903121100b0015e82088cc0mr9269728plh.52.1653041774274; Fri, 20 May 2022 03:16:14 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:c013:adc3:af5d:9cf8]) by smtp.gmail.com with ESMTPSA id s3-20020a170902c64300b0015e8d4eb2cfsm5154168pls.281.2022.05.20.03.16.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 May 2022 03:16:13 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id D687611406D7; Fri, 20 May 2022 19:46:10 +0930 (ACST) Date: Fri, 20 May 2022 19:46:10 +0930 From: Alan Modra To: =?iso-8859-1?Q?Cl=E9ment?= Chigot Cc: Nick Clifton , binutils@sourceware.org Subject: Re: [PATCH] ld: harmonize the value of --enable-warn-execstack=no option Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-3029.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 May 2022 10:16:18 -0000 On Fri, May 20, 2022 at 09:07:06AM +0200, Clément Chigot wrote: > However, the testsuite changes look mandatory to me. > As of now, the results are different dependending on the > configure options being passed. Yes, you may well be correct. I'm going to leave this to Nick. Incidentally, the reason why I didn't fix the arm/aarch64 regressions is that if link_info.separate_code = DEFAULT_LD_Z_SEPARATE_CODE; link_info.warn_execstack = DEFAULT_LD_WARN_EXECSTACK; link_info.no_warn_rwx_segments = ! DEFAULT_LD_WARN_RWX_SEGMENTS; link_info.default_execstack = DEFAULT_LD_EXECSTACK; is added to armelf.em:before_parse then we get FAIL: PR ld/29072 (ignore absent .note.GNU-stack) The reason being that arm is listed in ld/testsuite/ld-elf/elf.exp target_defaults_to_execstack but doesn't have elf_backend_default_execstack set. > If the warnings are disabled, ld/29072 will always fail. > If the warnings are forced, stack exec will fail too. > > I agree that forcing --warn-execstack might not be the > right approach. > Maybe disabling the problematic tests and creating > new ones: tests that are run only when a given > configure option is set, would be better. That way > we can also check that the behavior of each configure > choice is preserved. > > Clément -- Alan Modra Australia Development Lab, IBM