From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by sourceware.org (Postfix) with ESMTPS id 2D5133858C2C for ; Fri, 3 Jun 2022 13:23:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2D5133858C2C Received: by mail-pj1-x102c.google.com with SMTP id 3-20020a17090a174300b001e426a02ac5so8898257pjm.2 for ; Fri, 03 Jun 2022 06:23:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=U3+7Vvie8pAiOzE2e5PhXYd2weBJps6dPo1O8wL4PPA=; b=nWBzspBZs3/oWiUJMoPCKxxJLz/aAUCMLOUm1Jnsx79xXgMZ00y0CHKMZUCEYkJPtY cH7D/7qZr0WwNRxTqh6DNbJ9Ls1ksXEiBaLzVwBOERU+kUKu5+97MN5JC4/VfPkTKXYJ VVw8Cpe6VufyeaYJRmjpMhnTALFPyhkNstIOCaaIowHF5XMUzcLlHFbVifuYnQNcv8ho eLp/SDVYPYnUMTNt1RQxZBsYVFFQLVsI2/f9c71TwmmwbCtc+/YGlpeCr+MEwr1QqLcP V6PToHubqPviZ93zFFD8TWHgPw83O172X/Ln4VMAdD2D8UuAH+WhahbWzMdhSu8QhPNF gIjQ== X-Gm-Message-State: AOAM532MfB9cemjEXicNsYefpz1mGY4PvrPnfWTv5CLsJBau8ZXwNpqy U9+YKsFpHvBotAc42nl//BU446Kngqs= X-Google-Smtp-Source: ABdhPJzCVjsjDAhW9103cBupgOIuAG5sjME0snWKjjOev8u/nwWHiZuIA+Vxbj7I6euEAusK95Wgqg== X-Received: by 2002:a17:902:dac6:b0:161:f394:3e7a with SMTP id q6-20020a170902dac600b00161f3943e7amr10224631plx.19.1654262607771; Fri, 03 Jun 2022 06:23:27 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:cee2:94b4:7aba:6f26]) by smtp.gmail.com with ESMTPSA id 36-20020a630b24000000b003c14af505eesm5227722pgl.6.2022.06.03.06.23.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jun 2022 06:23:27 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 73FC811411C4; Fri, 3 Jun 2022 22:53:24 +0930 (ACST) Date: Fri, 3 Jun 2022 22:53:24 +0930 From: Alan Modra To: binutils@sourceware.org Subject: Re: ubsan: undefined shift in frag_align_code Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-3036.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jun 2022 13:23:31 -0000 This one needs the same fix too. * config/tc-i386.h (MAX_MEM_FOR_RS_ALIGN_CODE): Avoid signed integer overflow. diff --git a/gas/config/tc-i386.h b/gas/config/tc-i386.h index d7c6b33c778..817539ea560 100644 --- a/gas/config/tc-i386.h +++ b/gas/config/tc-i386.h @@ -207,7 +207,8 @@ if ((n) \ goto around; \ } -#define MAX_MEM_FOR_RS_ALIGN_CODE (alignment ? ((1 << alignment) - 1) : 1) +#define MAX_MEM_FOR_RS_ALIGN_CODE \ + (alignment ? ((size_t) 1 << alignment) - 1 : (size_t) 1) extern void i386_cons_align (int); #define md_cons_align(nbytes) i386_cons_align (nbytes) -- Alan Modra Australia Development Lab, IBM