From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by sourceware.org (Postfix) with ESMTPS id A86B83858D32 for ; Sun, 19 Jun 2022 23:50:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A86B83858D32 Received: by mail-pl1-x62a.google.com with SMTP id b10so1365562plg.4 for ; Sun, 19 Jun 2022 16:50:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tmy9Ciaq1nbN9D/qfjDAL9Q4c04JAIsgE0EciMAk31M=; b=tVBSTveZiiC418KbJziORRqeeFrUahjsNc8sekFWwsUsypHA7ixQiOEoJAa0MeHwjC IenhnyU/5GOqyNlMc4x48t+LAjEMJ5BaE4tGkbTPuTadHMC2n8UTO81QiqlnVVabhdCG 848p5h83iA4sjtxAL2a2C1d11QUnuuQyfSha2eJzmSn3ArN/Ax3GRe0P8ZWTI5VbSVxv 1sroHM9jEC96tfjD//3O8gt1069kWhvNH9Xt2bDc6/pkM977WbqgnQoM2aGZOJAWe07o Fr4dQbGezDaZGTUUr7jb0G5APwIq6gGXIkF3/fTgeoFJZaHWawDrFvTCOn5Q/eQ5CIo4 qs9Q== X-Gm-Message-State: AJIora/8QrkF+TZEhZ1pKgPuQ4AzGtt/ki3NXBztl0/9qPQwouzYW7Vj JkeEJahDv31YbPrqq7r6Fj7Eo5KSFUE= X-Google-Smtp-Source: AGRyM1tQk3s4On8bodRlYIbbYYJMw1X/EF20BJ0ByBHfhJ8+0vJy9a+pOg6M+d+EVkyu+Qt+QKDeMQ== X-Received: by 2002:a17:903:187:b0:166:4360:a4fa with SMTP id z7-20020a170903018700b001664360a4famr21307361plg.87.1655682602707; Sun, 19 Jun 2022 16:50:02 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:33d6:836c:74ca:6639]) by smtp.gmail.com with ESMTPSA id a1-20020a1709027e4100b0015e8d4eb1b6sm7285673pln.0.2022.06.19.16.50.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jun 2022 16:50:01 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id A1CB31140323; Mon, 20 Jun 2022 09:19:58 +0930 (ACST) Date: Mon, 20 Jun 2022 09:19:58 +0930 From: Alan Modra To: Dmitry Selyutin Cc: binutils@sourceware.org, luke.leighton@gmail.com Subject: Re: [PATCH 0/5] ppc/svp64: support SVP64 and its first insns Message-ID: References: <20220617190820.452821-1-ghostmansd@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220617190820.452821-1-ghostmansd@gmail.com> X-Spam-Status: No, score=-3028.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2022 23:50:06 -0000 On Fri, Jun 17, 2022 at 10:08:15PM +0300, Dmitry Selyutin wrote: > These patches introduce SVP64 extension and LibreSOC CPU which supports > this extension. We also provide the first 32-bit instructions, namely > setvl, svstep, svshape and svremap, plus the corresponding tests. These all look good to me, and can be pushed when your copyright assignment is complete. The only review comment I have is that #define SVme TO would be better for maintenance if placed with the TO definition, so that someone doesn't change the TO entry without realising they are also changing things for SVme. Similarly for the other aliases you define. -- Alan Modra Australia Development Lab, IBM