From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Subject: Correct R_MIPS_16 n32 howto
Date: Tue, 14 Jun 2022 10:02:12 +0930 [thread overview]
Message-ID: <YqfXDEnuLN34TKpi@squeak.grove.modra.org> (raw)
If the howto is actually used, an all-zero dst_mask will result in
unchanged section contents on attempting to apply R_MIPS_16.
* elfn32-mips.c (elf_mips_howto_table_rela <R_MIPS_16>): Correct
dst_mask.
diff --git a/bfd/elfn32-mips.c b/bfd/elfn32-mips.c
index b74d25f12f7..2027230c651 100644
--- a/bfd/elfn32-mips.c
+++ b/bfd/elfn32-mips.c
@@ -901,7 +901,7 @@ static reloc_howto_type elf_mips_howto_table_rela[] =
"R_MIPS_16", /* name */
false, /* partial_inplace */
0, /* src_mask */
- 0x0000, /* dst_mask */
+ 0x0000ffff, /* dst_mask */
false), /* pcrel_offset */
/* 32 bit relocation. */
--
Alan Modra
Australia Development Lab, IBM
reply other threads:[~2022-06-14 0:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqfXDEnuLN34TKpi@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).