From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by sourceware.org (Postfix) with ESMTPS id C8BBE3856DE8 for ; Fri, 17 Jun 2022 11:57:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C8BBE3856DE8 Received: by mail-pf1-x432.google.com with SMTP id z17so3988430pff.7 for ; Fri, 17 Jun 2022 04:57:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition; bh=YXc+YAT7Q1KCm8qdTo7xyTZmR/ytQGKdxrZfl8QIemU=; b=yht9C9FHOerntyb/1vh74uOh4xyPTJb6Rxms2GRKv8GrN6zBL8HYsUZjfznAWFEajk nYQD3i1XosfFy2OPGwTZ7FJbl1YFOizH1rbbM//ehhhpA7NuS3M1/q2g0IG+/eaem/tL wbpEyXW8qTW/8bzVUttdthgw9eUI8VboryKF0CRdRmf3ZuZoe5Tgh8m5LkXKcv5/c/x5 +3hGmJrYAqQW5XsfGrghghyRpZmIzAQlBjk3Zeg5puZ+sf1ucK9BQoaaQq7iydCQARZv +kjPz5RZZH37qe9yX0/HkVb6+3mXhCIonA5Zy1MsuXcWT4WFVbd+OIj1lSjVqpFeYHS9 y2AQ== X-Gm-Message-State: AJIora/aOCa25ixjYQhdyV4P3ksm8enPYx4RYTcbJB91ejZJbLDEDcaK qYrxKBVaSo6HleN9I9mhjaHMkawdta4= X-Google-Smtp-Source: AGRyM1uvM+kC6pOeYtGxBIRBqFSHhlDb7Vo7pedRv+tFF82CB1JdDQMvZKNDgRe6vUoSMzBL3M6QNw== X-Received: by 2002:a63:7f46:0:b0:3f6:26e7:30e2 with SMTP id p6-20020a637f46000000b003f626e730e2mr8573400pgn.508.1655467047510; Fri, 17 Jun 2022 04:57:27 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:1527:8623:b4c:ebc4]) by smtp.gmail.com with ESMTPSA id e3-20020a170903240300b0015ea3a491a1sm3393008plo.191.2022.06.17.04.57.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jun 2022 04:57:26 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id AAAC71140ABB; Fri, 17 Jun 2022 21:27:23 +0930 (ACST) Date: Fri, 17 Jun 2022 21:27:23 +0930 From: Alan Modra To: binutils@sourceware.org Subject: PR29254, memory leak in stab_demangle_v3_arg Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3036.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jun 2022 11:57:31 -0000 PR 29254 * stabs.c (stab_demangle_v3_arg): Free dt on failure path. diff --git a/binutils/stabs.c b/binutils/stabs.c index 2b5241637c1..796ff85b86a 100644 --- a/binutils/stabs.c +++ b/binutils/stabs.c @@ -5467,7 +5467,10 @@ stab_demangle_v3_arg (void *dhandle, struct stab_handle *info, dc->u.s_binary.right, &varargs); if (pargs == NULL) - return NULL; + { + free (dt); + return NULL; + } return debug_make_function_type (dhandle, dt, pargs, varargs); } -- Alan Modra Australia Development Lab, IBM